Skip to content

Update default for externalConsole to false#3828

Merged
pieandcakes merged 6 commits into
masterfrom
users/piel/defaultconsole
Jul 3, 2019
Merged

Update default for externalConsole to false#3828
pieandcakes merged 6 commits into
masterfrom
users/piel/defaultconsole

Conversation

@pieandcakes
Copy link
Copy Markdown
Contributor

@WardenGnaw anything i'm missing?

@pieandcakes pieandcakes requested a review from WardenGnaw June 25, 2019 17:52
@pieandcakes pieandcakes self-assigned this Jun 25, 2019
Copy link
Copy Markdown
Member

@WardenGnaw WardenGnaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's all there is.

@sean-mcmanus
Copy link
Copy Markdown
Contributor

What does this fix? #3385 ?

@WardenGnaw
Copy link
Copy Markdown
Member

This is for microsoft/vscode-remote-release#381

@pieandcakes pieandcakes merged commit 6b3c0f1 into master Jul 3, 2019
@pieandcakes pieandcakes deleted the users/piel/defaultconsole branch July 3, 2019 00:12
@sean-mcmanus sean-mcmanus added this to the June 2019 milestone Jul 3, 2019
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants