Update colorization support to only return tokens for currently visible ranges#3738
Merged
Conversation
added 4 commits
June 5, 2019 11:08
sean-mcmanus
approved these changes
Jun 7, 2019
…IntelliSense is disabled
…scode-cpptools into coleng/colorization2
sean-mcmanus
approved these changes
Jun 7, 2019
…ed files after reloading window. Prevent redundant reports of visibile range changes.
sean-mcmanus
reviewed
Jun 8, 2019
sean-mcmanus
requested changes
Jun 8, 2019
Contributor
sean-mcmanus
left a comment
sean-mcmanus
left a comment
There was a problem hiding this comment.
Existing open files doesn't work still. When I put a breakpoint here it starts working though, so there's some sort of race condition.
bobbrow
reviewed
Jun 11, 2019
…scode-cpptools into coleng/colorization2
…settings to use to colorize Visual Studio Light / Dark to look like VS
bobbrow
reviewed
Jun 12, 2019
sean-mcmanus
approved these changes
Jun 12, 2019
bobbrow
reviewed
Jun 12, 2019
This was referenced Jun 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, colorization would have issues with very large files consuming extensive resources on the TS side. This change maintains the tokens on the native side, and returns tokens only for currently visible regions. A return receipt is returned when handled, to allow throttling of colorization notifications.