Fix command not found and empty c_cpp_properties.json if activation is too slow.#3178
Merged
Conversation
sean-mcmanus
changed the title
sean-mcmanus
commented
Feb 15, 2019
|
|
||
| // Only register the real commands after the extension has finished initializing, | ||
| // e.g. prevents empty c_cpp_properties.json from generation. | ||
| registerCommands(); |
Contributor
Author
There was a problem hiding this comment.
I could delay only a subset of commands, but that didn't seem necessary to bother with.
sean-mcmanus
commented
Feb 15, 2019
Contributor
Author
sean-mcmanus
left a comment
sean-mcmanus
left a comment
There was a problem hiding this comment.
I could delay only a subset of commands, but that didn't seem necessary to bother with.
bobbrow
approved these changes
Feb 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #3160 and #3176.