Skip to content

Seanmcm/suggest snippets setting#3135

Merged
sean-mcmanus merged 3 commits into
masterfrom
seanmcm/suggestSnippetsSetting
Feb 5, 2019
Merged

Seanmcm/suggest snippets setting#3135
sean-mcmanus merged 3 commits into
masterfrom
seanmcm/suggestSnippetsSetting

Conversation

@sean-mcmanus
Copy link
Copy Markdown
Contributor

@sean-mcmanus sean-mcmanus commented Feb 5, 2019

Fix for #3083 . There are required language server changes too.

@sean-mcmanus sean-mcmanus requested a review from a team February 5, 2019 21:53
Comment thread Extension/package.json Outdated
"C_Cpp.suggestSnippets": {
"type": "boolean",
"default": true,
"description": "If true, snippets are provided from the language server.",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: from -> by

Copy link
Copy Markdown
Member

@bobbrow bobbrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the description and this is good to go.

@sean-mcmanus sean-mcmanus merged commit 7a20270 into master Feb 5, 2019
@sean-mcmanus sean-mcmanus deleted the seanmcm/suggestSnippetsSetting branch February 5, 2019 23:46
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants