Skip to content

Open the modified header for 'Extract to function'. #11670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sean-mcmanus merged 2 commits into from
Nov 13, 2023
Merged

Open the modified header for 'Extract to function'. #11670

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bddc0a2
Open the modified header for 'Extract to function'.
sean-mcmanus Nov 13, 2023
e72daa3
Fix comment.
sean-mcmanus Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Extension/src/LanguageServer/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3608,6 +3608,15 @@ export class DefaultClient implements Client {
return;
}

if (headerFormatUriAndRanges.length > 0) {
// The header needs to be open and shown or the formatting will fail
// (due to issues/requirements in the cpptools process).
// It also seems strange and undesirable to have the header modified
// without being opened because otherwise users may not realize that
// the header had changed (unless they view source control differences).
await vscode.window.showTextDocument(headerFormatUriAndRanges[0].uri, { preserveFocus: true });
}

// Apply the extract to function text edits.
await vscode.workspace.applyEdit(workspaceEdits, { isRefactoring: true });

Expand Down