Repository navigation
docs(api): correct adaptive chat completion cache doc (keyed by endpoint+model) - #1492
Open
PratikDhanave (PratikDhanave) wants to merge 1 commit into
Open
PratikDhanave (PratikDhanave) wants to merge 1 commit into
PratikDhanave (PratikDhanave) wants to merge 1 commit into
Conversation
…int+model)
The doc called the compatibility cache "model-independent", but cacheKey is
`${normalizedEndpoint}\n${model.trim()}` — learned compatibility is keyed by
endpoint AND model, not shared across models. The tests confirm it ("isolates
learned compatibility by endpoint and model"; LRU evicts after N
endpoint-model keys). Describe the actual behavior.
PratikDhanave (PratikDhanave)
requested a review
from Cedric Vidal (cedricvidal)
as a code owner
October 13, 2026 12:05
Cedric Vidal (cedricvidal)
added
the
community-contribution
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
postAdaptiveChatCompletion(apps/api/src/adaptive-chat-completions.ts) is documented as using a "process-local, model-independent compatibility cache", butcacheKey(endpoint, model)returns${normalizedEndpoint}\n${model.trim()}— learned compatibility is keyed by endpoint and model, not shared across models. The tests prove the opposite of the comment ("isolates learned compatibility by endpoint and model"; "evicts the least recently used entry after 100 endpoint-model keys"). Corrected the doc. Doc-only.