Repository navigation
docs(shared/resources): fix ResolveParamsResult.params precedence (profile wins) - #1491
Open
PratikDhanave (PratikDhanave) wants to merge 1 commit into
Open
PratikDhanave (PratikDhanave) wants to merge 1 commit into
PratikDhanave (PratikDhanave) wants to merge 1 commit into
Conversation
…ofile wins)
The field doc said "defaults, overlaid by profile, overlaid by run" (run wins),
but resolveParams merges `profileParams[name] ?? runParams[name] ?? default`
— profile wins. This matches the function JSDoc, the conflict logic, and the
tests ("prefers the profile value"; "keeps the profile value when a run tries
to override"). Correct the field doc.
PratikDhanave (PratikDhanave)
requested a review
from Cedric Vidal (cedricvidal)
as a code owner
October 13, 2026 12:05
Cedric Vidal (cedricvidal)
added
the
community-contribution
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ResolveParamsResult.params(packages/shared/src/resources/resource-params.ts) is documented asdefaults, overlaid by profile, overlaid by run— i.e. run wins. But the actual merge isprofileParams[name] ?? runParams[name] ?? declaration.default— profile wins. The field doc contradicts the function's own JSDoc ("the profile wins"), the conflict logic, and the tests (resource-params.test.ts: "prefers the profile value over the declared default"; "keeps the profile value when a run tries to override"). Corrected the field doc. Doc-only.