Skip to content

Fix model provider filter labels - #1471

Open
Cedric Vidal (cedricvidal) wants to merge 1 commit into
mainfrom
cedricvidal-fix/provider-filter-labels
Open

Cedric Vidal (cedricvidal) wants to merge 1 commit into
mainfrom
cedricvidal-fix/provider-filter-labels

Conversation

@cedricvidal

Copy link
Copy Markdown
Collaborator

Why

The Models page grouped filter options by Model.provider but rendered each provider value through AgentBadge as if it were an agent ID. Provider names therefore failed agent lookup and appeared as duplicate Unknown agent entries, making the filter ambiguous and unreliable.

What changed

  • Build provider filter options directly from the exact Model.provider values, preserving distinct labels, counts, and URL filter values.
  • Keep Model.agentId exclusively for the separate Agent filter and table badge.
  • Remove the redundant agent catalog request that was only used for the incorrect provider label lookup.
  • Add focused unit coverage for distinct provider labels, deterministic sorting, and grouped counts.
  • Document the Models page provider-versus-agent filter semantics.

Validation

  • pnpm test apps/portal/src/pages/model-provider-filter-options.test.ts - passed, 2 tests
  • pnpm --filter portal lint - passed
  • pnpm --filter portal build - passed

Walkthrough

provider-filter-walkthrough.mp4
Provider options

Provider filter showing distinct Anthropic and GitHub Copilot options

Filtered Anthropic models

Anthropic provider selected with two matching models

Fixes: #1469

@github-actions github-actions Bot added type: documentation Documentation additions, corrections, and improvements. language: javascript Work involving JavaScript code, tooling, or dependencies. area: portal Scope web portal, pages, and user-facing components. topic: testing Test coverage, test infrastructure, and validation quality. topic: ui Portal, visual presentation, layout, and interface components. labels Oct 8, 2026
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

Test Results (Node.js 22)

test: Run #208

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
3201 3201 0 0 0 0 0 59.4s

🎉 All tests passed!

Github Test Reporter

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: portal Scope web portal, pages, and user-facing components. language: javascript Work involving JavaScript code, tooling, or dependencies. topic: testing Test coverage, test infrastructure, and validation quality. topic: ui Portal, visual presentation, layout, and interface components. type: documentation Documentation additions, corrections, and improvements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Portal model provider filter displays providers as duplicate "Unknown agent" entries

1 participant