Repository navigation
fix(portal): keep nested entity previews in the full-bleed shell - #1464
Open
Ming You (itzKLAUS) wants to merge 1 commit into
Open
Ming You (itzKLAUS) wants to merge 1 commit into
Ming You (itzKLAUS) wants to merge 1 commit into
Conversation
Ming You (itzKLAUS)
requested review from
Cedric Vidal (cedricvidal) and
Wassim Chegham (manekinekko)
as code owners
October 6, 2026 09:08
Cedric Vidal (cedricvidal)
added
the
community-contribution
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The route patterns match the application routes and are covered by focused regressions and documentation.
Review effort: Balanced
Findings: None
What changed in this PR
Keeps seven nested entity previews within the Portal’s full-bleed list shell while preserving padding for standalone pages.
Changes:
- Adds exact full-bleed preview route patterns.
- Adds navigation, direct-load, padding, and Storybook regressions.
- Documents the Portal shell behavior.
| File | Description |
|---|---|
docs/architecture/app-design.md |
Documents preview-shell behavior. |
apps/portal/src/components/Layout.tsx |
Registers seven nested preview routes as full-bleed. |
apps/portal/src/components/Layout.test.tsx |
Tests preview navigation, direct loads, and standalone padding. |
apps/portal/src/components/Layout.stories.tsx |
Adds interactive synthetic preview stories. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Opening a nested preview under Reports, Insights, Criteria, Prompts, MCP servers, Extensions or Profiles adds the standard page padding to a full-bleed list, shifting its content. This is the follow-up requested in the review of #1459: #1459 (review).
Change
Add the seven exact nested preview patterns to
FULL_BLEED_ROUTE_PATTERNS. Ordinary detail and creation routes keep their padding. Add parameterized navigation/direct-load regressions, seven synthetic Storybook shell examples with interaction checks, and update the Portal Shell documentation.Based directly on upstream main; the separate key-preview fix in #1459 is not included.
Validation
tsc --noEmitpasses.Local Vitest used an uncommitted Windows-only config that normalizes the existing
@/alias path separators; no test behavior or dependency changes.