Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Fix performance bottleneck fetching module content - #742

Merged
Mikhail Arkhipov (MikhailArkhipov) merged 10 commits into
microsoft:masterfrom
MikhailArkhipov:perf
Mar 13, 2019
Merged

Mikhail Arkhipov (MikhailArkhipov) merged 10 commits into
microsoft:masterfrom
MikhailArkhipov:perf

Conversation

@MikhailArkhipov

Copy link
Copy Markdown
  • Cache document content. Converting string builder every time is a time sink and a memory waste.

Tensorflow is down to 50s
image

Original
image

Comment thread src/Analysis/Ast/Impl/Documents/DocumentBuffer.cs
@MikhailArkhipov
Mikhail Arkhipov (MikhailArkhipov) merged commit 8a4412c into microsoft:master Mar 13, 2019
Jake Bailey (jakebailey) pushed a commit to jakebailey/python-language-server that referenced this pull request Nov 1, 2019
* Fix microsoft#668 (partial)

* Tests

* Revert "Tests"

This reverts commit 7ffc9db.

* Cache document content
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants