This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Repository navigation
Unfilter __all__ - #708
Merged
Jake Bailey (jakebailey) merged 1 commit intoMar 6, 2019
Merged
Unfilter __all__#708
Conversation
Member
Author
|
Amending my statement: Even though the old LS didn't look at |
Mikhail Arkhipov (MikhailArkhipov)
approved these changes
Mar 6, 2019
Member
Author
|
Old LS exposed variable defs, which I think would be about the same as what I've written. I'll merge this and we can tweak it later; at least numpy works now. 😄 |
Jake Bailey (jakebailey)
added a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
Fixes microsoft#642. Reopens microsoft#619. Related microsoft#620. This unfilters exported variables except for things which are directly from typing or are imported modules, though even that may be too strong. The old LS didn't look at __all__ whatsoever, so maybe all of these should be allowed to come through; you tell me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #642.
Reopens #619.
Related #620.
This unfilters
__all__except for things which are directly fromtypingor are imported modules, though even that may be too strong. The old LS didn't look at__all__whatsoever, so maybe all of these should be allowed to come through; you tell me.Numpy: