Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Basic analysis progress reporting - #687

Merged
Mikhail Arkhipov (MikhailArkhipov) merged 4 commits into
microsoft:masterfrom
MikhailArkhipov:progress
Mar 5, 2019
Merged

Mikhail Arkhipov (MikhailArkhipov) merged 4 commits into
microsoft:masterfrom
MikhailArkhipov:progress

Conversation

@MikhailArkhipov

@MikhailArkhipov Mikhail Arkhipov (MikhailArkhipov) commented Mar 1, 2019 •

Copy link
Copy Markdown

Fixes #688

  • Numbers can go up/down. We can nix numbers and just leave the spinner if that is weird.
  • Special class that reduces frequency of reporting traffic and auto-disposes the message when there is no activity.

Comment thread src/Analysis/Ast/Impl/Analyzer/Definitions/IProgressReporter.cs Outdated
Comment thread src/Analysis/Ast/Impl/Analyzer/PythonAnalyzer.cs Outdated
Comment thread src/Analysis/Ast/Impl/Analyzer/PythonAnalyzer.cs Outdated
@MikhailArkhipov

Mikhail Arkhipov (MikhailArkhipov) commented Mar 2, 2019 •

Copy link
Copy Markdown
Author

Tweaked a bit. There is actually a bug in the extension, it misses beginProgress often b/c of sync issues. I will submit PR there separately.

@MikhailArkhipov

Copy link
Copy Markdown
Author

Extension fixed in microsoft/vscode-python#4620

Comment thread src/Analysis/Ast/Impl/Analyzer/ProgressReporter.cs
@MikhailArkhipov

Copy link
Copy Markdown
Author

Alexander Sher (@AlexanderSher) - is there anything better we could do at the moment?

@MikhailArkhipov
Mikhail Arkhipov (MikhailArkhipov) merged commit 6bd6ebb into microsoft:master Mar 5, 2019
Jake Bailey (jakebailey) added a commit that referenced this pull request Mar 6, 2019
Running analysis tests after #687 fails because there is no progress reporting service.
Jake Bailey (jakebailey) pushed a commit to jakebailey/python-language-server that referenced this pull request Nov 1, 2019
* Fix microsoft#668 (partial)

* Progress reporting

* Tweaked
Jake Bailey (jakebailey) added a commit to jakebailey/python-language-server that referenced this pull request Nov 1, 2019
Running analysis tests after microsoft#687 fails because there is no progress reporting service.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants