This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Repository navigation
Wire up restart of analysis on changes in configuration - #684
Merged
Mikhail Arkhipov (MikhailArkhipov) merged 3 commits intoMar 1, 2019
Merged
Conversation
added 2 commits
February 28, 2019 16:55
| } else { | ||
| _log?.Log(TraceEventType.Error, "change configuration notification sent unsupported settings"); | ||
| switch (@params.settings) { | ||
| case null: |
Contributor
There was a problem hiding this comment.
No logging for null?
There was a problem hiding this comment.
Actually, we should log it since server should not be sending this.
Alexander Sher (AlexanderSher)
approved these changes
Mar 1, 2019
Jake Bailey (jakebailey)
pushed a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
* Wire up config changes * Fix error * Log null settings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also upgrade dependencies.