This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Bug fixes#418
Merged
MikhailArkhipov merged 10 commits intomicrosoft:masterfrom Nov 23, 2018
MikhailArkhipov:master
Merged
Conversation
jakebailey
reviewed
Nov 19, 2018
jakebailey
reviewed
Nov 21, 2018
jakebailey
reviewed
Nov 21, 2018
added 2 commits
November 21, 2018 09:07
jakebailey
reviewed
Nov 21, 2018
jakebailey
approved these changes
Nov 23, 2018
Member
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
Unless there's something else you want to address, LGTM.
| public override IEnumerable<ILocationInfo> Locations => _original.Locations?.MaybeEnumerate(); | ||
|
|
||
| public override string Name => _original == null ? base.Name : this._original.Name; | ||
| public override string Name => _original == null ? base.Name : _original.Name; |
Contributor
There was a problem hiding this comment.
Why in this case we call base.Name, and in previous explicitly return empty enumerable instead of calling base.Locations, which also returns empty enumerable?
Author
There was a problem hiding this comment.
Good question. No idea.
| return Enumerable.Empty<ILocationInfo>(); | ||
| } | ||
| return defns.Definitions.Select(l => l.GetLocationInfo()).Where(l => l != null); | ||
| return defns.Definitions.Select(l => l.GetLocationInfo()).ExcludeDefault(); |
Contributor
There was a problem hiding this comment.
Looks like we have two almost identical methods: ExcludeDefaults and WhereNotNull.
Author
There was a problem hiding this comment.
Yes ExcludeDefault came from RTVS extensions, looks like WhereNotNull is local thing
added 3 commits
November 23, 2018 14:55
jakebailey
pushed a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #397 (remove name protocol from tuple)
Fixes #383 (do not return nulls, return empty sets)
Fixes #378 (null check)
Fixes #379 (explicit protocol comparison)