This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Repository navigation
Add submodules to completion list - #1896
Merged
Mikhail Arkhipov (MikhailArkhipov) merged 30 commits intoFeb 10, 2020
Merged
Conversation
added 30 commits
September 30, 2019 12:03
This reverts commit 6109ac7.
| public virtual IMember GetMember(string name) => GlobalScope.Variables[name]?.Value; | ||
|
|
||
| public virtual IEnumerable<string> GetMemberNames() => GlobalScope.GetExportableVariableNames(); | ||
| public virtual IMember GetMember(string name) { |
There was a problem hiding this comment.
This modifies all accesses, not just the completion for imports. Is this what you expect? Not sure if we had removed this behavior or modified at some point in the past or not... Vaguely remember something like this previously and having to be careful to present things in the right place.
There was a problem hiding this comment.
Yes, if it is a legal member Python can find, it should be exposed. I looked into past history and found that handling of submodules was added for import statement completion specifically. This code is basically borrowed from there.
Jake Bailey (jakebailey)
approved these changes
Feb 10, 2020
Mikhail Arkhipov (MikhailArkhipov)
pushed a commit
that referenced
this pull request
Mar 19, 2020
This reverts commit c66e404.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1870