This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Repository navigation
Look for module of the definition in RDT during rename - #1790
Merged
Jake Bailey (jakebailey) merged 20 commits intoNov 13, 2019
Merged
Conversation
added 17 commits
September 30, 2019 12:03
Mikhail Arkhipov (MikhailArkhipov)
changed the title
Member
|
#1788 is merged, so this needs a master merge to fix the diff. |
added 2 commits
November 12, 2019 16:54
Member
|
Is there any way to test this fix? |
Author
|
Probably yes, need to add file to what we have in tests so it is considered a library. Let me try that. |
Jake Bailey (jakebailey)
approved these changes
Nov 13, 2019
Mikhail Arkhipov (MikhailArkhipov)
pushed a commit
that referenced
this pull request
Jun 15, 2020
* Remove stale reference * Don't suppress LHS diagnostics on augmented assign * Look for module in RDT * Less nesting * Add test (cherry picked from commit 56b0342)
Mikhail Arkhipov (MikhailArkhipov)
pushed a commit
that referenced
this pull request
Jun 15, 2020
* Remove stale reference * Don't suppress LHS diagnostics on augmented assign * Look for module in RDT * Less nesting * Add test (cherry picked from commit 56b0342)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #979
Variables do not have declaring module so we need to look in RDT, like goto definition does.
Includes #1788 by accident so it needs to go last. Actual change is one file at the end.