This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Repository navigation
Fallback to function when property's declaringType is unknown - #1416
Merged
Merged
Conversation
Jake Bailey (jakebailey)
requested a review
from Mikhail Arkhipov (MikhailArkhipov)
August 7, 2019 17:45
Mikhail Arkhipov (MikhailArkhipov)
approved these changes
Aug 7, 2019
Jake Bailey (jakebailey)
added a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1335, for now.
This could stand to be improved by somehow allowing the declaring type to be null, but that is a more complicated fix, and just falling back to a function provides some usability and stops the NREs.