Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Check if #noqa is present in line before adding diagnostic - #1272

Merged
Cameron Trando (CTrando) merged 14 commits into
microsoft:masterfrom
CTrando:scratch/NoQAImpl
Jul 15, 2019
Merged

Cameron Trando (CTrando) merged 14 commits into
microsoft:masterfrom
CTrando:scratch/NoQAImpl

Conversation

@CTrando

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread src/Analysis/Ast/Impl/Analyzer/Evaluation/ExpressionEval.cs Outdated
Comment thread src/Analysis/Ast/Impl/Diagnostics/DiagnosticsEntry.cs Outdated
Comment thread src/Analysis/Ast/Test/LintNoQATests.cs Outdated
Comment thread src/Analysis/Ast/Impl/Modules/PythonModule.cs Outdated
Comment thread src/Analysis/Ast/Impl/Modules/PythonModule.cs Outdated
Comment thread src/Analysis/Ast/Impl/Extensions/PythonModuleExtensions.cs Outdated
Comment thread src/Analysis/Ast/Impl/Extensions/PythonModuleExtensions.cs Outdated
Comment thread src/Analysis/Ast/Impl/Diagnostics/DiagnosticsEntry.cs Outdated
Comment thread src/Analysis/Ast/Impl/Extensions/PythonModuleExtensions.cs Outdated
Comment thread src/Analysis/Ast/Impl/Diagnostics/DiagnosticsEntry.cs Outdated
Comment thread src/Analysis/Ast/Impl/Diagnostics/DiagnosticsEntry.cs Outdated
Comment thread src/Analysis/Ast/Impl/Extensions/AstExtensions.cs Outdated
… make sure noqa works fine if it's not in a comment
Comment thread src/Analysis/Ast/Impl/Diagnostics/DiagnosticsEntry.cs Outdated
Comment thread src/Analysis/Ast/Impl/Extensions/PythonModuleExtensions.cs Outdated
Comment thread src/Analysis/Ast/Impl/Extensions/AstExtensions.cs Outdated
Comment thread src/Analysis/Ast/Impl/Extensions/AstExtensions.cs Outdated
Comment thread src/Analysis/Ast/Impl/Extensions/AstExtensions.cs Outdated
Comment thread src/Analysis/Ast/Impl/Extensions/AstExtensions.cs
Comment thread src/Analysis/Ast/Impl/Extensions/PythonModuleExtensions.cs Outdated
Comment thread src/Analysis/Ast/Impl/Diagnostics/DiagnosticsEntry.cs
Comment thread src/Analysis/Ast/Test/LintNoQATests.cs
Comment thread src/Analysis/Ast/Impl/Diagnostics/DiagnosticsEntry.cs
Comment thread src/Analysis/Ast/Impl/Extensions/PythonModuleExtensions.cs Outdated
@MikhailArkhipov

Copy link
Copy Markdown

Add test for "NOQA" and return string.Empty. Otherwise LGTM.

@CTrando
Cameron Trando (CTrando) merged commit 2b6befa into microsoft:master Jul 15, 2019
Jake Bailey (jakebailey) pushed a commit to jakebailey/python-language-server that referenced this pull request Nov 1, 2019
…#1272)

* Adding general noqa functionality, so can disable diagnostics for a line by adding a comment with noqa
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants