This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Repository navigation
Do not evaluate library functions with various arguments - #1047
Merged
Mikhail Arkhipov (MikhailArkhipov) merged 42 commits intoMay 8, 2019
Merged
Mikhail Arkhipov (MikhailArkhipov) merged 42 commits into
Mikhail Arkhipov (MikhailArkhipov) merged 42 commits into
Conversation
added 30 commits
March 1, 2019 09:51
This reverts commit 7ffc9db.
added 11 commits
April 10, 2019 15:37
| // Try and evaluate with specific arguments. Note that it does not | ||
| // make sense to evaluate stubs since they already should be annotated. | ||
| if (fn.DeclaringModule is IDocument doc && fd?.Ast == doc.GetAnyAst()) { | ||
| if (EvaluateFunctionBody(fn) && fn.DeclaringModule is IDocument doc && fd?.Ast == doc.GetAnyAst()) { |
Contributor
There was a problem hiding this comment.
We can call EvaluateFunctionBody after checking fn.DeclaringModule is IDocument doc && fd?.Ast == doc.GetAnyAst()
Alexander Sher (AlexanderSher)
approved these changes
May 8, 2019
Jake Bailey (jakebailey)
pushed a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
) * Fix microsoft#668 (partial) * Tests * Revert "Tests" This reverts commit 7ffc9db. * Exp * Limit concurrency * Concurrency limit * Drop cache after analysis * Fix regression * Fix test * Limit body analysis in libraries * More skipping * Fix test * Walk library functions once * Add comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do evaluate function body once and if we are able to figure out return type, we have it. Walking function body with assorted arguments, even with caching takes quite a bit of time for little bang for the buck.
This does not apply to user code.