Skip to content
This repository was archived by the owner on Apr 14, 2022. It is now read-only.
This repository was archived by the owner on Apr 14, 2022. It is now read-only.

Generic LoggedVar example no longer works #732

Description

v no longer has a type that makes sense:

from typing import TypeVar, Generic
from logging import Logger, getLogger

T = TypeVar('T')

class LoggedVar(Generic[T]):
    def __init__(self, value: T, name: str, logger: Logger) -> None:
        self.name = name
        self.logger = logger
        self.value = value

    def set(self, new: T) -> None:
        self.log('Set ' + repr(self.value))
        self.value = new

    def get(self) -> T:
        self.log('Get ' + repr(self.value))
        return self.value

    def log(self, message: str) -> None:
        self.logger.info('%s: %s', self.name, message)

v = LoggedVar(1234, "name", getLogger("oh_no"))
v.get()

image

We regressed somewhere; I'll bisect it.

Activity

  1. jakebailey commented on Mar 11, 2019

    @jakebailey
    MemberAuthor

    Before #666:

    image

    Neither are correct, so this isn't exactly a regression, just something we should fix around Generic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions