PLS does not resolve base class expressions in correct scope

Consider the following Python code:

class ContainerClass():
    class BaseClass(object):
        def __init__(self, name):
            self.name = name

    class SubClass(BaseClass):
        def __init__(self): 
            super().__init__('')

The PLS analyzer logic incorrectly reports that BaseClass is referenced before being defined. In looking at the PLS code, AnalysisUnit.AnalyzeWorker is calling EvaluateBaseClass from within the scope of the subclass rather than its outer (containing) class.

I think this can be fixed by modifying AnalysisUnit.AnalyzeWorker to temporarily set the scope of the ddg to the outer scope before calling EvaluateBaseClass. Something like this:

// Evaluate base classes in the outer scope.
if (_outerUnit.Scope is InterpreterScope) {
    ddg.Scope = _outerUnit.Scope as InterpreterScope;
}
bases.Add(EvaluateBaseClass(ddg, classInfo, i, baseClassArg.Expression));
ddg.Scope = InterpreterScope;

Comment in #513

I confirmed this bug still exists in the newly-refactored code as well.

New code does not report definition order... And there is no language server that uses new code yet. The only thing that exists for the new code is unit tests... I checked this snipped in a unit test to make sure there are no parse errors, there are none.

Not applicable after #546. The offending code is gone.

Navigation Menu

Repository navigation

PLS does not resolve base class expressions in correct scope #508

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

PLS does not resolve base class expressions in correct scope #508

Description

Activity

MikhailArkhipov commented on Dec 27, 2018

erictraut commented on Dec 27, 2018

MikhailArkhipov commented on Dec 28, 2018

MikhailArkhipov commented on Feb 9, 2019

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions