Implement rename functionality #4

Activity

1. Mikhail Arkhipov (MikhailArkhipov)

   self-assigned this

   on Aug 31, 2018
2. Mikhail Arkhipov (MikhailArkhipov)

   added

   enhancementNew feature or requestNew feature or request

   on Aug 31, 2018
3. MikhailArkhipov commented on Sep 5, 2018

   

   Mikhail Arkhipov (MikhailArkhipov)

   on Sep 5, 2018

   Author

   More actions

   #16
4. Mikhail Arkhipov (MikhailArkhipov)

   closed this as completedon Sep 5, 2018
5. Mikhail Arkhipov (MikhailArkhipov)

   added this to the Sep 2018 milestone on Sep 5, 2018
6. brettcannon commented on Oct 1, 2018

   

   Brett Cannon (brettcannon)

   on Oct 1, 2018

   Member

   More actions

   Is this implemented in version 0.1.38.0? I just tried it and I keep getting:

   [Error - 4:21:17 PM] Request textDocument/rename failed.
     Message: unknown document
     Code: -32000 
   [object Object]
   

   when trying to rename any variable in

   def foo(x):
       w = x * 3
       y = w * 5
       return y
7. MikhailArkhipov commented on Oct 1, 2018

   

   Mikhail Arkhipov (MikhailArkhipov)

   on Oct 1, 2018

   Author

   More actions

   It is. Looks like URI conversion fix was lost in merges. Restored - 1.40 should have the fix.

   🎉React with 🎉1Reacted by Brett Cannon
8. brettcannon commented on Oct 2, 2018

   

   Brett Cannon (brettcannon)

   on Oct 2, 2018

   Member

   More actions

   Thanks! I have validated the fix.
9. Mikhail Arkhipov (MikhailArkhipov)

   added a commit that references this issue on Sep 16, 2019

   Lint on no method argument, no self argument, no cls argument (#1510)

   ...

   3ccb213