This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Repository navigation
This repository was archived by the owner on Apr 14, 2022. It is now read-only.
@property outside of class definition causes NRE #1335
Description
Activity
Doesn't even have to be outside of a class; scikit-learn's deprecation util library hits this:
class deprecation: def _decorate_property(self, prop): msg = self.extra @property def wrapped(*args, **kwargs): warnings.warn(msg, category=DeprecationWarning) return prop.fget(*args, **kwargs) return wrapped
declaringTypeis null.I'm not entirely sure how properties work now, but we may need to stop attaching them to any one type, and just let their existence as a member of something else be enough to distinguish them.
We can either not create the odd property or make it a standalone function if there is no declared type. I guess problem is that it gets member type of property or method and that implies declaring type.
Generally we don't handle classes or inner functions inside other functions very well in master atm. I fixed a number of this cases in persistence branch.
- assigned and unassigned
on Aug 7, 2019
ex:
causes an NRE because declaringType is null for functions outside of a class scope, and in the constructor for PythonPropertyType we do not check for null declaring type.