Only report build failure when the build errors are on the running project's classpath - #459
Conversation
Jinbo Wang (testforstephen)
commented
Nov 17, 2022
Jinbo Wang (testforstephen)
commented
- For a build-tool managed project, will check if the running project and its references projects contain build errors. If so, report build failure. Otherwise, return succeed.
- For unmanaged folder, only check if the running main class contains build errors. If so, report build failure. Otherwise, return succeed.
…ing project's classpath
|
I'm thinking that how we can re-use the code in https://github.com/eclipse/eclipse.jdt.ls/blob/d4101ae14289ff7db98763cf731a0c74138589b8/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/BuildWorkspaceHandler.java#L100 Now we build the entire workspace but only check the markers for the trigger project. That means we may waste some time for building unrelated projects. |
I will hold on current behavior first before the performance becomes a concern. |
2 participants
