Show target VM exceptions as result in evaluate requests - #428
Merged
Jinbo Wang (testforstephen) merged 1 commit intoJul 22, 2022
Merged
Conversation
This changes the result of an expression like `Long.parseLong("foo")`
sent to the evaluate handler from:
org.eclipse.debug.core.DebugException: com.sun.jdi.InvocationException: Exception occurred in target VM occurred invoking method.
to the actual exception:
NumberFormatException@76 "java.lang.NumberFormatException: For input string: "foo""
backtrace: Object[6]@82
cause: NumberFormatException@76
depth: 46
detailMessage: "For input string: "foo""
stackTrace: StackTraceElement[0]@84
suppressedExceptions: Collections$EmptyList@85 size=0
Mathias Fußenegger (mfussenegger)
force-pushed
the
vm-exceptions
branch
from
July 20, 2022 16:27
b7871a9 to
2aabfed
Compare
Jinbo Wang (testforstephen)
approved these changes
Jul 22, 2022
Jinbo Wang (testforstephen)
left a comment
Jinbo Wang (testforstephen)
left a comment
Contributor
There was a problem hiding this comment.
Mathias Fußenegger (@mfussenegger) It's a nice improvement. Thanks for contribution.
36 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the result of an expression like
Long.parseLong("foo")sent to the evaluate handler from:
to the actual exception:
I think this makes the console in vscode and other DAP clients more useful as you get a more meaningful result for expressions that fail