Skip to content

Fix the InvalidStackFrameException when getting variables at the exception breakpoint #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jinbo Wang (testforstephen) merged 1 commit into from
Jul 14, 2020
Merged

Fix the InvalidStackFrameException when getting variables at the exception breakpoint #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .../main/java/com/microsoft/java/debug/core/adapter/handler/ExceptionInfoRequestHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,15 @@ public CompletableFuture<Response> handle(Command command, Arguments arguments,
} catch (InvalidTypeException | ClassNotLoadedException | IncompatibleThreadStateException
| InvocationException e) {
logger.log(Level.SEVERE, String.format("Failed to get the return value of the method Exception.toString(): %s", e.toString(), e));
} finally {
try {
// See bug https://github.com/microsoft/vscode-java-debug/issues/767:
// The operation exception.invokeMethod above will resume the thread, that will cause
// the previously cached stack frames for this thread to be invalid.
context.getStackFrameManager().reloadStackFrames(thread);
} catch (Exception e) {
// do nothing.
}
}
}

Expand Down
6 changes: 4 additions & 2 deletions ...bug.core/src/main/java/com/microsoft/java/debug/core/adapter/variables/VariableUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,10 @@ public static List<Variable> listLocalVariables(StackFrame stackFrame) throws Ab
return res;
}
try {
for (LocalVariable localVariable : stackFrame.visibleVariables()) {
Variable var = new Variable(localVariable.name(), stackFrame.getValue(localVariable));
List<LocalVariable> localVariables = stackFrame.visibleVariables();
Map<LocalVariable, Value> values = stackFrame.getValues(localVariables);
for (LocalVariable localVariable : localVariables) {
Variable var = new Variable(localVariable.name(), values.get(localVariable));
var.local = localVariable;
res.add(var);
}
Expand Down