Display the method return value when stepping out - #336
Merged
Jinbo Wang (testforstephen) merged 5 commits intoJul 6, 2020
Merged
Jinbo Wang (testforstephen) merged 5 commits into
Jinbo Wang (testforstephen) merged 5 commits into
Conversation
Contributor
Author
|
|
Jinbo Wang (testforstephen)
requested review from
Yan Zhang (Eskibear),
Rome Li (akaroml),
Andy Xu(devdiv) (andxu) and
Sheng Chen (jdneo)
June 23, 2020 08:47
Jinbo Wang (testforstephen)
force-pushed
the
jinbo_methodreturn
branch
from
June 23, 2020 12:04
9695f6d to
d2cffbd
Compare
Signed-off-by: Jinbo Wang <[email protected]>
Jinbo Wang (testforstephen)
force-pushed
the
jinbo_methodreturn
branch
from
July 1, 2020 06:17
d2cffbd to
ed3a3b1
Compare
Jinbo Wang (testforstephen)
marked this pull request as ready for review
July 1, 2020 06:18
Signed-off-by: Jinbo Wang <[email protected]>
Member
|
What if the method has parameters? And what will it looks like when it's a invocation chain (like stream invocation) |
Signed-off-by: Jinbo Wang <[email protected]>
Sheng Chen (jdneo)
previously approved these changes
Jul 2, 2020
Member
|
With this icon '⎯►', then why you still need to append "returned", for better clarification? |
Signed-off-by: Jinbo Wang <[email protected]>
Contributor
Author
|
Addressed, below is the new look. |
Signed-off-by: Jinbo Wang <[email protected]>
Sheng Chen (jdneo)
approved these changes
Jul 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jinbo Wang [email protected]
Close microsoft/vscode-java-debug#660