Skip to content

skip cleanup when attached to the process #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Marek Żarnowski (mzarnowski) wants to merge 3 commits into from
Closed

skip cleanup when attached to the process #284

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
447dae0
skip cleanup when attached to the process
Jun 28, 2019
fcb14cd
Merge branch 'master' into ignore-resource-cleanup-for-attached-process
testforstephen Jun 28, 2019
6288e93
fix code style
Jun 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .../java/com/microsoft/java/debug/core/adapter/handler/AbstractDisconnectRequestHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@ private void destroyResource(IDebugAdapterContext context) {
}

private boolean shouldDestroyLaunchFiles(IDebugAdapterContext context) {
if (context.isAttached()) {
return false; // the debugger is not an owner of the process, so the cleanup can be ignored.
}

// Delete the temporary launch files must happen after the debuggee process is fully exited,
// otherwise it throws error saying the file is being used by other process.
// In Debug mode, the debugger is able to receive VM terminate event. It's sensible to do cleanup.
Expand Down