For different project types, use the corresponding class provider to resolve the runtime classpath - #281
Merged
Conversation
…resolve the runtime classpath Signed-off-by: Jinbo Wang <[email protected]>
Jinbo Wang (testforstephen)
requested review from
Rome Li (akaroml),
Andy Xu(devdiv) (andxu) and
Sheng Chen (jdneo)
June 14, 2019 08:58
Andy Xu(devdiv) (andxu)
approved these changes
Jun 14, 2019
Sheng Chen (jdneo)
approved these changes
Jun 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jinbo Wang [email protected]
Fix microsoft/vscode-java-debug#584
Fix microsoft/vscode-java-debug#566
Currently, we're using
JavaRuntime.resolveRuntimeClasspath(IJavaProject)API, there are two limitation for it.testscope.The fix is to use the corresponding class provider for different project type to resolve the runtime classpath.