Skip to content

Clean up engineering setting debts. #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yaohaizh merged 1 commit into from
Apr 2, 2018
Merged

Clean up engineering setting debts. #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion com.microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/DebugUtility.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public class DebugUtility {

/**
* Launch a debuggee in suspend mode.
* @see {@link #launch(VirtualMachineManager, String, String, String, String, String)}
* @see #launch(VirtualMachineManager, String, String, String, String, String)
*/
public static IDebugSession launch(VirtualMachineManager vmManager,
String mainClass,
Expand Down
2 changes: 1 addition & 1 deletion ...microsoft.java.debug.core/src/main/java/com/microsoft/java/debug/core/UsageDataStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ private static final class SingletonHolder {
}

/**
* Fetch all pending user data records
* Fetch all pending user data records.
* @return List of user data Object.
*/
public synchronized Object[] fetchAll() {
Expand Down
4 changes: 3 additions & 1 deletion com.microsoft.java.debug.plugin/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ Require-Bundle: org.eclipse.core.runtime,
org.eclipse.jdt.debug,
org.eclipse.jdt.core,
org.eclipse.jdt.ls.core,
org.eclipse.jdt.launching
org.eclipse.jdt.launching,
com.google.gson;bundle-version="2.7.0",
org.apache.commons.lang3;bundle-version="3.1.0"
Bundle-ClassPath: lib/gson-2.7.jar,
.,
lib/rxjava-2.1.1.jar,
Expand Down
10 changes: 0 additions & 10 deletions com.microsoft.java.debug.plugin/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,6 @@
<artifactId>maven-dependency-plugin</artifactId>
<configuration>
<artifactItems>
<artifactItem>
<groupId>com.google.code.gson</groupId>
<artifactId>gson</artifactId>
<version>2.7</version>
</artifactItem>
<artifactItem>
<groupId>io.reactivex.rxjava2</groupId>
<artifactId>rxjava</artifactId>
Expand All @@ -42,11 +37,6 @@
<artifactId>reactive-streams</artifactId>
<version>1.0.0</version>
</artifactItem>
<artifactItem>
<groupId>org.apache.commons</groupId>
<artifactId>commons-lang3</artifactId>
<version>3.6</version>
</artifactItem>
<artifactItem>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
Expand Down