Skip to content
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
1984063
Add location type check on breakpoint
andxu Dec 11, 2017
c6e1ae3
fix breakpoint pos
andxu Dec 11, 2017
7b095bc
Merge branch 'master' into andxu-patch-bp
andxu Dec 11, 2017
ee27393
1. add the logic to avoid duplicate install breakpoint when updated b…
andxu Dec 11, 2017
339449a
revert unneeded change.
andxu Dec 11, 2017
22e4750
removes invalid breakpoint
andxu Dec 11, 2017
47ff43a
fix checkstyle hint.
andxu Dec 11, 2017
7ecd159
Merge branch 'master' into andxu-patch-bp
andxu Dec 12, 2017
6ec20f1
Merge branch 'master' into andxu-patch-bp
andxu Dec 12, 2017
194dd5b
Update typo in javadoc
andxu Dec 13, 2017
6d8ba11
remove useless if condition
andxu Dec 13, 2017
65a6c57
remove tailing spaces.
andxu Dec 13, 2017
7e1b821
Merge remote-tracking branch 'origin' into andxu-patch-bp
andxu Dec 14, 2017
d78e201
Merge branch 'master' into andxu-patch-bp
andxu Dec 15, 2017
342283c
Merge branch 'master' into andxu-patch-bp
andxu Dec 18, 2017
68178db
Merge branch 'master' into andxu-patch-bp
andxu Dec 19, 2017
56250bb
Merge branch 'andxu-patch-bp' of https://github.com/Microsoft/java-de…
andxu Dec 20, 2017
c013519
Merge branch 'master' into andxu-patch-bp
andxu Dec 21, 2017
3a8a683
Merge branch 'andxu-patch-bp' of https://github.com/Microsoft/java-de…
andxu Dec 21, 2017
4fed5c9
Merge branch 'master' into andxu-patch-bp
andxu Dec 22, 2017
4795edb
update javadoc
andxu Dec 22, 2017
96af742
Merge remote-tracking branch 'origin/andxu-patch-bp' into andxu-patch-bp
andxu Dec 22, 2017
04d3f3b
Merge branch 'master' into andxu-patch-bp
andxu Jan 16, 2018
93c187b
Merge branch 'master' into andxu-patch-bp
andxu Feb 22, 2018
5e4b3ab
Merge branch 'master' into andxu-patch-bp
andxu Mar 5, 2018
afb2d76
revert the code to modify line numbers because in vscode, the action …
andxu Mar 6, 2018
611fbf0
revert changes.
andxu Mar 6, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,8 @@ public String[] getFullyQualifiedName(String uri, int[] lines, int[] columns) th
ValidBreakpointLocationLocator locator = new ValidBreakpointLocationLocator(astUnit, lines[i], true, true);
astUnit.accept(locator);
// When the final valid line location is same as the original line, that represents it's a valid breakpoint.
if (lines[i] == locator.getLineLocation()) {
// Add location type check to avoid breakpoint on method/field which will never be hit in current implementation.
if (lines[i] == locator.getLineLocation() && locator.getLocationType() == ValidBreakpointLocationLocator.LOCATION_LINE) {
fqns[i] = locator.getFullyQualifiedTypeName();
}
}
Expand Down