Repository navigation
Get Python 3.13 to work - #1692
Merged
Merged
Conversation
Contributor
Author
|
I believe this also fixes attach? Still verifying, but all the attach tests were passing for me locally. |
Karthik Nadig (karthiknadig)
requested changes
Oct 9, 2024
Karthik Nadig (karthiknadig)
left a comment
Karthik Nadig (karthiknadig)
left a comment
Member
There was a problem hiding this comment.
Minor change
Karthik Nadig (karthiknadig)
approved these changes
Oct 10, 2024
| # Not currently supported in Python 3.12. | ||
| SUPPORT_ATTACH_TO_PID = not IS_PY312_OR_GREATER | ||
| # Not currently supported in Python 3.14. | ||
| SUPPORT_ATTACH_TO_PID = not IS_PY314_OR_GREATER |
There was a problem hiding this comment.
Do we know that attach doesn't work in 3.14 for some reason?
Contributor
Author
There was a problem hiding this comment.
It might work, but the code in the attach logic explicitly only allows up to 3.13. This is just matching that logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were a number of internal changes in CPython that were preventing 3.13 from working.
This change fixes all of those spots to use a public API or something that works in all versions.
Addresses #1689