Fix case where dependent target, needed to evaluate condition, is skipped because condition is false.#396
Merged
Scottj1s merged 2 commits intomicrosoft:masterfrom Oct 24, 2019
Conversation
…ped because condition is false.
Scottj1s
approved these changes
Oct 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSBuild won't run targets listed in DependsOnTargets if the target is skipped due to a false condition.
In this case, the condition to run the MakeReferenceProjection input is dependent on one of the DependsOnTargets targets, causing an issue in cases where that target didn't run earlier.
The fix is a technique recommended by the MSBuild team and already used elsewhere in the targets file:
We apply this by having a CppWinRTResolveReferences target and have the MakeReferenceProjections target have a dependency on this new target.
Tested
Fixes #395