Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

[Patch] SSO + Teams: maintain sign in link for channels that require it #1245

Merged
axelsrz merged 4 commits into from
Jul 13, 2020
Merged

[Patch] SSO + Teams: maintain sign in link for channels that require it #1245

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cbbad4b
SSO + Teams: maintain sign in link for channels that require it
carlosscastro Jul 13, 2020
c0749bb
Fix syntax :)
carlosscastro Jul 13, 2020
822c16e
OAuthPrompt: Formatting
carlosscastro Jul 13, 2020
6bbe16a
Merge branch '4.9' of https://github.com/microsoft/botbuilder-python …
axelsrz Jul 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion libraries/botbuilder-dialogs/botbuilder/dialogs/prompts/oauth_prompt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,9 @@ async def _send_oauth_card(
):
if context.activity.channel_id == Channels.emulator:
card_action_type = ActionTypes.open_url
else:
elif not OAuthPrompt._channel_requires_sign_in_link(
context.activity.channel_id
):
link = None

json_token_ex_resource = (
Expand Down Expand Up @@ -617,6 +619,13 @@ def _channel_suppports_oauth_card(channel_id: str) -> bool:

return True

@staticmethod
def _channel_requires_sign_in_link(channel_id: str) -> bool:
if channel_id in [Channels.ms_teams]:
return True

return False

@staticmethod
def _is_token_exchange_request_invoke(context: TurnContext) -> bool:
activity = context.activity
Expand Down