Lint unit tests via harnessSources in Jakefile.js - #8785
Conversation
|
Andy (Andrewkraft) (@Andy-MS) can you take a look? |
| }); | ||
| var lintTargets = compilerSources | ||
| .concat(harnessCoreSources) | ||
| .concat(harnessSources) |
There was a problem hiding this comment.
Don't need client.ts added manually below, that's already in harnessSources.
There was a problem hiding this comment.
Thanks for the reminder. fixed.
|
👍 |
| ///<reference path='..\..\..\..\src\harness\harness.ts' /> | ||
|
|
||
| describe("DocumentRegistry", () => { | ||
| /* tslint:disable no-unused-variable */ |
There was a problem hiding this comment.
Should there be an issue reminding us to go and fix things like this later?
There was a problem hiding this comment.
No, these variables are intentionally unused because they are testing state sharing between instances.
|
Printing |
|
I'm not sure of the correct Javascript way to do this. Gets rid of 3 dupes: protocol.d.ts, session.ts and editorServices.ts. |
|
👍 |
3 participants
A couple of preprocessing tests needed to change because of deleting trailing whitespace. Otherwise the changes are straightforward.
Fixes #8763