Skip to content

Report the member name instead of the signature in deprecation suggestions #64443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GON (gonappuccino) wants to merge 3 commits into
base: main
Choose a base branch
from
+86 −1
Open

Report the member name instead of the signature in deprecation suggestions #64443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6bfa7b
Report the member name instead of the signature in deprecation sugges…
gonappuccino Sep 25, 2026
275af7e
Also report private member names in deprecation suggestions
gonappuccino Sep 25, 2026
82012d3
Skip parentheses around the callee when naming a deprecated signature
gonappuccino Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion tsc/internal/checker/checker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8539,7 +8539,18 @@ func (c *Checker) checkDeprecatedSignature(sig *Signature, node *ast.Node) {
}
if sig.declaration != nil && c.IsDeprecatedDeclaration(sig.declaration) {
suggestionNode := c.getDeprecatedSuggestionNode(node)
name := tryGetPropertyAccessOrIdentifierToString(ast.GetInvokedExpression(node))
invokedExpression := ast.SkipParentheses(ast.GetInvokedExpression(node))
name := tryGetPropertyAccessOrIdentifierToString(invokedExpression)
if name == "" {
switch {
case ast.IsPropertyAccessExpression(invokedExpression):
name = invokedExpression.Name().Text()
case ast.IsElementAccessExpression(invokedExpression):
if memberName := ast.GetElementOrPropertyAccessName(invokedExpression); memberName != nil {
name = memberName.Text()
}
}
}
c.addDeprecatedSuggestionWithSignature(suggestionNode, sig.declaration, name, c.signatureToString(sig))
}
}
Expand Down
74 changes: 74 additions & 0 deletions tsc/internal/fourslash/tests/deprecatedSignatureMemberName_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
package fourslash_test

import (
"testing"

"github.com/microsoft/TypeScript/tsc/internal/fourslash"
"github.com/microsoft/TypeScript/tsc/internal/lsp/lsproto"
"github.com/microsoft/TypeScript/tsc/internal/testutil"
)

func TestDeprecatedSignatureMemberName(t *testing.T) {
t.Parallel()
defer testutil.RecoverAndFail(t, "Panic on fourslash test")
const content = `// @filename: /a.ts
interface Schema {
/** @deprecated */
passthrough(): Schema;
}
declare function object(): Schema;
object().[|passthrough|]();
object()[[|"passthrough"|]]();
(object().[|passthrough|])();
class C {
/** @deprecated */
m() {}
/** @deprecated */
#p() {}
n() {
this.[|m|]();
this.[|#p|]();
}
}`
f, done := fourslash.NewFourslash(t, nil /*capabilities*/, content)
defer done()
f.VerifySuggestionDiagnostics(t, []*lsproto.Diagnostic{
{
Code: &lsproto.IntegerOrString{Integer: new(int32(6387))},
Message: lsproto.StringOrMarkupContent{String: new("The signature '(): Schema' of 'passthrough' is deprecated.")},
Tags: &[]lsproto.DiagnosticTag{lsproto.DiagnosticTagDeprecated},
Range: f.Ranges()[0].LSRange,
},
{
Code: &lsproto.IntegerOrString{Integer: new(int32(6387))},
Message: lsproto.StringOrMarkupContent{String: new("The signature '(): Schema' of 'passthrough' is deprecated.")},
Tags: &[]lsproto.DiagnosticTag{lsproto.DiagnosticTagDeprecated},
Range: f.Ranges()[1].LSRange,
},
// A parenthesized callee also reports the deprecated property itself; that suggestion is unchanged.
{
Code: &lsproto.IntegerOrString{Integer: new(int32(6385))},
Message: lsproto.StringOrMarkupContent{String: new("'passthrough' is deprecated.")},
Tags: &[]lsproto.DiagnosticTag{lsproto.DiagnosticTagDeprecated},
Range: f.Ranges()[2].LSRange,
},
{
Code: &lsproto.IntegerOrString{Integer: new(int32(6387))},
Message: lsproto.StringOrMarkupContent{String: new("The signature '(): Schema' of 'passthrough' is deprecated.")},
Tags: &[]lsproto.DiagnosticTag{lsproto.DiagnosticTagDeprecated},
Range: f.Ranges()[2].LSRange,
},
{
Code: &lsproto.IntegerOrString{Integer: new(int32(6387))},
Message: lsproto.StringOrMarkupContent{String: new("The signature '(): void' of 'm' is deprecated.")},
Tags: &[]lsproto.DiagnosticTag{lsproto.DiagnosticTagDeprecated},
Range: f.Ranges()[3].LSRange,
},
{
Code: &lsproto.IntegerOrString{Integer: new(int32(6387))},
Message: lsproto.StringOrMarkupContent{String: new("The signature '(): void' of '#p' is deprecated.")},
Tags: &[]lsproto.DiagnosticTag{lsproto.DiagnosticTagDeprecated},
Range: f.Ranges()[4].LSRange,
},
})
}