Fixes #5789.#5841
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
should not this be task_1.Task?
Contributor
Author
There was a problem hiding this comment.
Thanks, didn't catch that one. I've pushed an update for this.
Contributor
|
can we add a test with async getter. |
Contributor
|
and would not say no to other tests as well, with aliases and imports and internal modules as well. |
Contributor
Author
|
@mhegazy: Async getters are not in the formal spec proposal for Async functions. |
Contributor
|
👍 |
Contributor
Author
|
I'll add a few more tests and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This worked previously, as the approach we were using in the past was checking the type as an expression which marked the import as referenced. That approach ran into issues with type aliases, which were addressed in a recent PR. However, there wasn't a test defined to capture this behavior. This PR fixes the issue directly and adds a test to ensure there will be no future regressions.
Edit by @DanielRosenwasser: Fixes #5789