Skip to content

Report binder diagnostics, program diagnostics as well as file pre processing diagnostics in javascript file#5839

Merged
sheetalkamat merged 8 commits into
masterfrom
jsBinderErrors
Dec 3, 2015
Merged

Report binder diagnostics, program diagnostics as well as file pre processing diagnostics in javascript file#5839
sheetalkamat merged 8 commits into
masterfrom
jsBinderErrors

Conversation

@sheetalkamat
Copy link
Copy Markdown
Member

@sheetalkamat sheetalkamat commented Nov 30, 2015

Handles #5785

mhegazy
mhegazy reviewed Nov 30, 2015
View reviewed changes
Comment thread tests/baselines/reference/jsFileCompilationExportAssignmentSyntax.errors.txt
Copy link
Copy Markdown
Contributor

@mhegazy mhegazy Nov 30, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not think we should report this one for js files.

Copy link
Copy Markdown
Member Author

@sheetalkamat sheetalkamat Dec 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this should be error only if !noEmit But what if we are emitting? what will we emit?
What should happen for

export class c {
}

Copy link
Copy Markdown
Contributor

@mhegazy mhegazy Dec 3, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see.. but it is still annoying for the JS language service scenarios.

@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Nov 30, 2015

i think we need to go through all binder errors and see if we should not report some of them for JS files.

@sheetalkamat
Copy link
Copy Markdown
Member Author

sheetalkamat commented Dec 2, 2015

@mhegazy , it seems like all the binder diagnostics are fine to report. I am looking into program diagnostics and file preprocessing diagnostics to see if they make sense in JS file
Also some of the duplicate symbol error (eg because of merging the symbol) are reported in checker. So I wonder if we should look at some of the checker errors and see if we want to report them. eg. #5838

@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Dec 3, 2015

👍

sheetalkamat added a commit that referenced this pull request Dec 3, 2015
@sheetalkamat
Merge pull request #5839 from Microsoft/jsBinderErrors
0ab538f 
Report binder diagnostics, program diagnostics as well as file pre processing diagnostics in javascript file
@sheetalkamat sheetalkamat merged commit 0ab538f into master Dec 3, 2015
@sheetalkamat sheetalkamat deleted the jsBinderErrors branch December 3, 2015 23:45
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sheetalkamat @mhegazy @msftclas