Skip to content

check computed property names in overloads#52427

Merged
jakebailey merged 1 commit into
microsoft:mainfrom
Zzzen:check-overloads-with-computed-names
Mar 8, 2023
Merged

check computed property names in overloads#52427
jakebailey merged 1 commit into
microsoft:mainfrom
Zzzen:check-overloads-with-computed-names

Conversation

@Zzzen
Copy link
Copy Markdown
Contributor

@Zzzen Zzzen commented Jan 26, 2023

Fixes #17345
Fixes #52329

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jan 26, 2023
@DanielRosenwasser
Copy link
Copy Markdown
Member

DanielRosenwasser commented Jan 26, 2023

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot perf test this faster

@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Jan 26, 2023 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at 5c19889. You can monitor the build here.

@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Jan 26, 2023 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at 5c19889. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Jan 26, 2023 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the diff-based top-repos suite on this PR at 5c19889. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Jan 26, 2023 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the diff-based user code test suite on this PR at 5c19889. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Jan 26, 2023

@DanielRosenwasser Here are the results of running the user test suite comparing main and refs/pull/52427/merge:

Everything looks good!

@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Jan 26, 2023

Heya @DanielRosenwasser, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Jan 26, 2023

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..52427

Metric main 52427 Delta Best Worst
Angular - node (v16.17.1, x64)
Memory used 359,206k (± 0.01%) 359,209k (± 0.01%) +2k (+ 0.00%) 359,186k 359,241k
Parse Time 4.17s (± 0.55%) 4.18s (± 0.10%) +0.01s (+ 0.28%) 4.18s 4.19s
Bind Time 1.22s (± 0.52%) 1.22s (± 0.42%) +0.00s (+ 0.27%) 1.22s 1.23s
Check Time 9.40s (± 0.35%) 9.40s (± 0.39%) +0.00s (+ 0.05%) 9.37s 9.47s
Emit Time 8.06s (± 0.65%) 8.05s (± 0.41%) -0.00s (- 0.06%) 8.02s 8.09s
Total Time 22.85s (± 0.25%) 22.86s (± 0.17%) +0.01s (+ 0.06%) 22.82s 22.93s
Compiler-Unions - node (v16.17.1, x64)
Memory used 194,205k (± 0.04%) 194,219k (± 0.05%) +15k (+ 0.01%) 194,130k 194,351k
Parse Time 1.80s (± 0.29%) 1.81s (± 0.46%) +0.00s (+ 0.09%) 1.79s 1.81s
Bind Time 0.85s (± 0.00%) 0.84s (± 0.90%) -0.01s (- 1.37%) 0.83s 0.85s
Check Time 10.36s (± 0.57%) 10.36s (± 0.47%) -0.00s (- 0.00%) 10.30s 10.43s
Emit Time 3.06s (± 1.52%) 3.05s (± 0.57%) -0.01s (- 0.22%) 3.03s 3.08s
Total Time 16.07s (± 0.52%) 16.06s (± 0.31%) -0.01s (- 0.08%) 15.98s 16.12s
Monaco - node (v16.17.1, x64)
Memory used 343,261k (± 0.01%) 343,262k (± 0.01%) +1k (+ 0.00%) 343,202k 343,326k
Parse Time 3.15s (± 1.40%) 3.17s (± 1.04%) +0.02s (+ 0.74%) 3.12s 3.22s
Bind Time 1.11s (± 0.37%) 1.11s (± 0.47%) -0.00s (- 0.15%) 1.10s 1.11s
Check Time 7.71s (± 0.07%) 7.73s (± 0.56%) +0.01s (+ 0.17%) 7.66s 7.78s
Emit Time 4.50s (± 0.77%) 4.52s (± 0.17%) +0.02s (+ 0.44%) 4.51s 4.53s
Total Time 16.48s (± 0.22%) 16.52s (± 0.47%) +0.05s (+ 0.30%) 16.41s 16.63s
TFS - node (v16.17.1, x64)
Memory used 299,768k (± 0.01%) 299,759k (± 0.00%) -8k (- 0.00%) 299,736k 299,769k
Parse Time 2.49s (± 1.47%) 2.50s (± 0.75%) +0.01s (+ 0.27%) 2.47s 2.52s
Bind Time 1.26s (± 0.41%) 1.26s (± 0.44%) -0.00s (- 0.13%) 1.25s 1.26s
Check Time 7.18s (± 0.20%) 7.20s (± 0.26%) +0.02s (+ 0.32%) 7.18s 7.23s
Emit Time 4.23s (± 0.83%) 4.19s (± 0.46%) -0.03s (- 0.79%) 4.16s 4.21s
Total Time 15.15s (± 0.30%) 15.15s (± 0.25%) -0.00s (- 0.02%) 15.09s 15.19s
material-ui - node (v16.17.1, x64)
Memory used 476,092k (± 0.02%) 476,076k (± 0.01%) -16k (- 0.00%) 475,988k 476,140k
Parse Time 3.70s (± 0.33%) 3.73s (± 0.17%) +0.03s (+ 0.72%) 3.72s 3.74s
Bind Time 1.02s (± 0.74%) 1.02s (± 0.00%) +0.00s (+ 0.16%) 1.02s 1.02s
Check Time 18.06s (± 0.23%) 18.04s (± 0.37%) -0.02s (- 0.13%) 17.95s 18.14s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 22.78s (± 0.18%) 22.79s (± 0.28%) +0.00s (+ 0.01%) 22.70s 22.88s
xstate - node (v16.17.1, x64)
Memory used 546,227k (± 0.01%) 546,173k (± 0.01%) -54k (- 0.01%) 546,129k 546,211k
Parse Time 4.75s (± 0.25%) 4.76s (± 0.37%) +0.01s (+ 0.21%) 4.74s 4.79s
Bind Time 1.81s (± 3.84%) 1.84s (± 0.49%) +0.03s (+ 1.56%) 1.83s 1.85s
Check Time 3.00s (± 2.69%) 2.97s (± 0.35%) -0.03s (- 1.06%) 2.95s 2.98s
Emit Time 0.09s (± 5.53%) 0.09s (± 5.53%) -0.00s (- 0.00%) 0.09s 0.10s
Total Time 9.65s (± 0.19%) 9.65s (± 0.21%) +0.00s (+ 0.02%) 9.63s 9.68s
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • Angular - node (v16.17.1, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Monaco - node (v16.17.1, x64)
  • TFS - node (v16.17.1, x64)
  • material-ui - node (v16.17.1, x64)
  • xstate - node (v16.17.1, x64)
Benchmark Name Iterations
Current 52427 6
Baseline main 6

Developer Information:

Download Benchmark

@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Jan 26, 2023

@DanielRosenwasser Here are the results of running the top-repos suite comparing main and refs/pull/52427/merge:

Everything looks good!

@jakebailey
Copy link
Copy Markdown
Member

jakebailey commented Mar 7, 2023

Results are a little old, so, rerunning:

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this

@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Mar 7, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the perf test suite on this PR at 5c19889. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Mar 7, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the parallelized Definitely Typed test suite on this PR at 5c19889. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Mar 7, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the extended test suite on this PR at 5c19889. You can monitor the build here.

@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Mar 7, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based user code test suite on this PR at 5c19889. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Mar 7, 2023 •
edited
Loading

Heya @jakebailey, I've started to run the diff-based top-repos suite on this PR at 5c19889. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Mar 7, 2023

@jakebailey Here are the results of running the user test suite comparing main and refs/pull/52427/merge:

Everything looks good!

@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Mar 8, 2023

@jakebailey Here are the results of running the top-repos suite comparing main and refs/pull/52427/merge:

Everything looks good!

@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Mar 8, 2023

Hey @jakebailey, the results of running the DT tests are ready.
There were interesting changes:

Branch only errors:

Package: inquirer
Error:

Error: /home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/DefinitelyTyped/types/inquirer/inquirer-tests.ts:232:5
ERROR: 232:5  expect  TypeScript@local compile error: 
Unused '@ts-expect-error' directive.
ERROR: 234:9  expect  TypeScript@local compile error: 
No overload matches this call.
  Overload 1 of 2, '(observerOrNext?: Partial<Observer<{ name: string; answer: any; }>> | ((value: { name: string; answer: any; }) => void) | undefined): Subscription', gave the following error.
    Type '(value: {    name_: string;    answer: number;}) => void' is not assignable to type '(value: { name: string; answer: any; }) => void'.
      Types of parameters 'value' and 'value' are incompatible.
        Property 'name_' is missing in type '{ name: string; answer: any; }' but required in type '{ name_: string; answer: number; }'.
  Overload 2 of 2, '(next?: ((value: { name: string; answer: any; }) => void) | null | undefined, error?: ((error: any) => void) | null | undefined, complete?: (() => void) | null | undefined): Subscription', gave the following error.
    Argument of type '{ next: (value: {    name_: string;    answer: number;}) => void; }' is not assignable to parameter of type '(value: { name: string; answer: any; }) => void'.
      Object literal may only specify known properties, and 'next' does not exist in type '(value: { name: string; answer: any; }) => void'.
ERROR: 260:5  expect  TypeScript@local compile error: 
Unused '@ts-expect-error' directive.
ERROR: 262:9  expect  TypeScript@local compile error: 
No overload matches this call.
  Overload 1 of 2, '(observerOrNext?: Partial<Observer<QuestionAnswer<{ str: string; num: number; }>>> | ((value: QuestionAnswer<{ str: string; num: number; }>) => void) | undefined): Subscription', gave the following error.
    Type '(value: {    name: string;    answer: number;}) => void' is not assignable to type '(value: QuestionAnswer<{ str: string; num: number; }>) => void'.
      Types of parameters 'value' and 'value' are incompatible.
        Type 'QuestionAnswer<{ str: string; num: number; }>' is not assignable to type '{ name: string; answer: number; }'.
          Type '{ name: "str"; answer: string; }' is not assignable to type '{ name: string; answer: number; }'.
            Types of property 'answer' are incompatible.
              Type 'string' is not assignable to type 'number'.
  Overload 2 of 2, '(next?: ((value: QuestionAnswer<{ str: string; num: number; }>) => void) | null | undefined, error?: ((error: any) => void) | null | undefined, complete?: (() => void) | null | undefined): Subscription', gave the following error.
    Argument of type '{ next: (value: {    name: string;    answer: number;}) => void; }' is not assignable to parameter of type '(value: QuestionAnswer<{ str: string; num: number; }>) => void'.
      Object literal may only specify known properties, and 'next' does not exist in type '(value: QuestionAnswer<{ str: string; num: number; }>) => void'.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

Package: inquirer/v8
Error:

Error: /home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/DefinitelyTyped/types/inquirer/v8/inquirer-tests.ts:234:5
ERROR: 234:5  expect  TypeScript@local compile error: 
Unused '@ts-expect-error' directive.
ERROR: 236:9  expect  TypeScript@local compile error: 
No overload matches this call.
  Overload 1 of 2, '(observerOrNext?: Partial<Observer<{ name: string; answer: any; }>> | ((value: { name: string; answer: any; }) => void) | undefined): Subscription', gave the following error.
    Type '(value: {    name_: string;    answer: number;}) => void' is not assignable to type '(value: { name: string; answer: any; }) => void'.
      Types of parameters 'value' and 'value' are incompatible.
        Property 'name_' is missing in type '{ name: string; answer: any; }' but required in type '{ name_: string; answer: number; }'.
  Overload 2 of 2, '(next?: ((value: { name: string; answer: any; }) => void) | null | undefined, error?: ((error: any) => void) | null | undefined, complete?: (() => void) | null | undefined): Subscription', gave the following error.
    Argument of type '{ next: (value: {    name_: string;    answer: number;}) => void; }' is not assignable to parameter of type '(value: { name: string; answer: any; }) => void'.
      Object literal may only specify known properties, and 'next' does not exist in type '(value: { name: string; answer: any; }) => void'.
ERROR: 262:5  expect  TypeScript@local compile error: 
Unused '@ts-expect-error' directive.
ERROR: 264:9  expect  TypeScript@local compile error: 
No overload matches this call.
  Overload 1 of 2, '(observerOrNext?: Partial<Observer<QuestionAnswer<{ str: string; num: number; }>>> | ((value: QuestionAnswer<{ str: string; num: number; }>) => void) | undefined): Subscription', gave the following error.
    Type '(value: {    name: string;    answer: number;}) => void' is not assignable to type '(value: QuestionAnswer<{ str: string; num: number; }>) => void'.
      Types of parameters 'value' and 'value' are incompatible.
        Type 'QuestionAnswer<{ str: string; num: number; }>' is not assignable to type '{ name: string; answer: number; }'.
          Type '{ name: "str"; answer: string; }' is not assignable to type '{ name: string; answer: number; }'.
            Types of property 'answer' are incompatible.
              Type 'string' is not assignable to type 'number'.
  Overload 2 of 2, '(next?: ((value: QuestionAnswer<{ str: string; num: number; }>) => void) | null | undefined, error?: ((error: any) => void) | null | undefined, complete?: (() => void) | null | undefined): Subscription', gave the following error.
    Argument of type '{ next: (value: {    name: string;    answer: number;}) => void; }' is not assignable to parameter of type '(value: QuestionAnswer<{ str: string; num: number; }>) => void'.
      Object literal may only specify known properties, and 'next' does not exist in type '(value: QuestionAnswer<{ str: string; num: number; }>) => void'.

    at testTypesVersion (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:194:15)
    at async runTests (/home/vsts/work/1/s/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/@definitelytyped/dtslint/dist/index.js:151:9)

You can check the log here.

@jakebailey
Copy link
Copy Markdown
Member

jakebailey commented Mar 8, 2023

@gabritto I've seen that above DT change listed on two unrelated PRs now; is there something wrong with the DT runner diff?

@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Mar 8, 2023

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52427
Metric main 52427 Delta Best Worst p-value
Angular - node (v18.10.0, x64)
Memory used 359,814k (± 0.01%) 359,812k (± 0.01%) ~ 359,741k 359,848k p=0.748 n=6
Parse Time 3.53s (± 0.70%) 3.49s (± 0.80%) -0.04s (- 1.09%) 3.46s 3.54s p=0.036 n=6
Bind Time 1.13s (± 0.66%) 1.14s (± 0.45%) ~ 1.13s 1.14s p=0.247 n=6
Check Time 8.63s (± 0.32%) 8.65s (± 0.73%) ~ 8.58s 8.75s p=0.809 n=6
Emit Time 7.43s (± 0.50%) 7.44s (± 0.88%) ~ 7.35s 7.52s p=0.686 n=6
Total Time 20.72s (± 0.31%) 20.72s (± 0.48%) ~ 20.62s 20.85s p=0.936 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used 191,693k (± 1.19%) 192,589k (± 1.49%) ~ 190,723k 196,335k p=0.575 n=6
Parse Time 1.48s (± 0.66%) 1.48s (± 0.35%) ~ 1.47s 1.48s p=0.348 n=6
Bind Time 0.77s (± 1.58%) 0.76s (± 0.68%) ~ 0.76s 0.77s p=0.923 n=6
Check Time 9.36s (± 0.84%) 9.37s (± 0.51%) ~ 9.32s 9.46s p=0.520 n=6
Emit Time 2.73s (± 0.82%) 2.71s (± 0.69%) ~ 2.70s 2.75s p=0.328 n=6
Total Time 14.34s (± 0.51%) 14.33s (± 0.38%) ~ 14.28s 14.43s p=0.872 n=6
Monaco - node (v18.10.0, x64)
Memory used 343,860k (± 0.02%) 343,842k (± 0.01%) ~ 343,778k 343,890k p=0.575 n=6
Parse Time 2.62s (± 1.22%) 2.63s (± 1.04%) ~ 2.60s 2.67s p=0.570 n=6
Bind Time 1.01s (± 0.51%) 1.01s (± 0.81%) ~ 0.99s 1.01s p=0.114 n=6
Check Time 7.04s (± 0.37%) 7.02s (± 0.59%) ~ 6.99s 7.10s p=0.226 n=6
Emit Time 4.23s (± 1.05%) 4.21s (± 0.63%) ~ 4.18s 4.24s p=0.517 n=6
Total Time 14.91s (± 0.51%) 14.87s (± 0.54%) ~ 14.78s 14.98s p=0.422 n=6
TFS - node (v18.10.0, x64)
Memory used 299,871k (± 0.01%) 299,886k (± 0.01%) ~ 299,859k 299,912k p=0.378 n=6
Parse Time 2.05s (± 1.22%) 2.04s (± 1.10%) ~ 2.02s 2.08s p=0.935 n=6
Bind Time 1.14s (± 0.66%) 1.14s (± 0.45%) ~ 1.13s 1.14s p=0.784 n=6
Check Time 6.52s (± 0.44%) 6.50s (± 0.64%) ~ 6.45s 6.55s p=0.295 n=6
Emit Time 3.87s (± 1.30%) 3.85s (± 0.97%) ~ 3.80s 3.89s p=0.376 n=6
Total Time 13.58s (± 0.58%) 13.52s (± 0.51%) ~ 13.44s 13.64s p=0.296 n=6
material-ui - node (v18.10.0, x64)
Memory used 476,455k (± 0.00%) 476,437k (± 0.01%) ~ 476,405k 476,474k p=0.230 n=6
Parse Time 3.12s (± 1.30%) 3.13s (± 0.37%) ~ 3.11s 3.14s p=1.000 n=6
Bind Time 0.91s (± 1.66%) 0.91s (± 0.83%) ~ 0.90s 0.92s p=0.933 n=6
Check Time 17.11s (± 0.54%) 17.04s (± 0.40%) ~ 16.99s 17.17s p=0.145 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 21.13s (± 0.63%) 21.08s (± 0.34%) ~ 21.03s 21.22s p=0.470 n=6
xstate - node (v18.10.0, x64)
Memory used 548,932k (± 0.02%) 548,919k (± 0.02%) ~ 548,863k 549,123k p=0.572 n=6
Parse Time 4.08s (± 0.56%) 4.07s (± 0.48%) ~ 4.04s 4.09s p=0.416 n=6
Bind Time 1.69s (± 0.61%) 1.68s (± 1.02%) ~ 1.65s 1.70s p=0.737 n=6
Check Time 2.77s (± 1.24%) 2.77s (± 1.44%) ~ 2.72s 2.84s p=0.810 n=6
Emit Time 0.08s (± 4.99%) 0.08s (± 0.00%) ~ 0.08s 0.08s p=0.405 n=6
Total Time 8.63s (± 0.54%) 8.61s (± 0.64%) ~ 8.56s 8.71s p=0.261 n=6
Angular - node (v16.17.1, x64)
Memory used 359,099k (± 0.00%) 359,101k (± 0.01%) ~ 359,065k 359,153k p=0.748 n=6
Parse Time 3.72s (± 0.44%) 3.70s (± 0.41%) ~ 3.69s 3.73s p=0.062 n=6
Bind Time 1.20s (± 0.43%) 1.19s (± 0.63%) ~ 1.18s 1.20s p=0.247 n=6
Check Time 9.47s (± 0.33%) 9.42s (± 0.48%) ~ 9.36s 9.47s p=0.107 n=6
Emit Time 7.92s (± 0.78%) 7.93s (± 0.48%) ~ 7.88s 7.98s p=0.936 n=6
Total Time 22.32s (± 0.37%) 22.25s (± 0.30%) ~ 22.18s 22.34s p=0.127 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 192,440k (± 0.01%) 192,909k (± 0.69%) ~ 192,328k 195,629k p=0.109 n=6
Parse Time 1.57s (± 0.40%) 1.55s (± 0.95%) -0.02s (- 1.17%) 1.53s 1.57s p=0.024 n=6
Bind Time 0.82s (± 0.50%) 0.82s (± 0.50%) ~ 0.82s 0.83s p=0.218 n=6
Check Time 10.08s (± 0.58%) 10.14s (± 0.59%) ~ 10.07s 10.21s p=0.148 n=6
Emit Time 3.00s (± 0.63%) 3.01s (± 0.91%) ~ 2.97s 3.04s p=0.871 n=6
Total Time 15.46s (± 0.38%) 15.52s (± 0.43%) ~ 15.42s 15.60s p=0.172 n=6
Monaco - node (v16.17.1, x64)
Memory used 343,121k (± 0.00%) 343,112k (± 0.01%) ~ 343,083k 343,145k p=0.688 n=6
Parse Time 2.78s (± 0.71%) 2.78s (± 0.60%) ~ 2.76s 2.80s p=0.738 n=6
Bind Time 1.08s (± 0.48%) 1.08s (± 0.50%) ~ 1.08s 1.09s p=0.640 n=6
Check Time 7.71s (± 0.50%) 7.68s (± 0.65%) ~ 7.64s 7.77s p=0.373 n=6
Emit Time 4.44s (± 1.29%) 4.43s (± 0.89%) ~ 4.39s 4.50s p=1.000 n=6
Total Time 16.01s (± 0.40%) 15.98s (± 0.47%) ~ 15.91s 16.12s p=0.377 n=6
TFS - node (v16.17.1, x64)
Memory used 299,246k (± 0.01%) 299,241k (± 0.00%) ~ 299,220k 299,253k p=0.471 n=6
Parse Time 2.16s (± 0.68%) 2.16s (± 0.64%) ~ 2.14s 2.17s p=0.458 n=6
Bind Time 1.25s (± 0.83%) 1.24s (± 0.41%) ~ 1.24s 1.25s p=0.437 n=6
Check Time 7.19s (± 0.65%) 7.17s (± 0.37%) ~ 7.14s 7.21s p=0.571 n=6
Emit Time 4.35s (± 0.73%) 4.34s (± 0.48%) ~ 4.31s 4.37s p=0.461 n=6
Total Time 14.95s (± 0.33%) 14.90s (± 0.36%) ~ 14.84s 15.00s p=0.125 n=6
material-ui - node (v16.17.1, x64)
Memory used 475,671k (± 0.00%) 475,695k (± 0.01%) ~ 475,639k 475,789k p=0.471 n=6
Parse Time 3.29s (± 0.46%) 3.28s (± 0.25%) ~ 3.27s 3.29s p=0.069 n=6
Bind Time 0.96s (± 0.85%) 0.96s (± 0.42%) ~ 0.96s 0.97s p=0.206 n=6
Check Time 18.05s (± 0.66%) 18.06s (± 0.16%) ~ 18.03s 18.10s p=0.376 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.30s (± 0.59%) 22.30s (± 0.09%) ~ 22.28s 22.33s p=0.377 n=6
xstate - node (v16.17.1, x64)
Memory used 546,459k (± 0.02%) 546,590k (± 0.02%) ~ 546,460k 546,688k p=0.128 n=6
Parse Time 4.25s (± 0.21%) 4.26s (± 0.50%) ~ 4.23s 4.29s p=0.285 n=6
Bind Time 1.76s (± 0.47%) 1.76s (± 0.78%) ~ 1.73s 1.77s p=0.340 n=6
Check Time 2.98s (± 1.10%) 2.99s (± 0.60%) ~ 2.97s 3.01s p=0.519 n=6
Emit Time 0.09s (± 5.53%) 0.09s (± 5.53%) ~ 0.09s 0.10s p=1.000 n=6
Total Time 9.09s (± 0.37%) 9.10s (± 0.37%) ~ 9.06s 9.15s p=0.519 n=6
Angular - node (v14.15.1, x64)
Memory used 352,874k (± 0.00%) 352,880k (± 0.00%) ~ 352,874k 352,887k p=0.107 n=6
Parse Time 3.69s (± 0.27%) 3.69s (± 0.47%) ~ 3.67s 3.72s p=0.615 n=6
Bind Time 1.25s (± 0.41%) 1.25s (± 0.44%) ~ 1.24s 1.25s p=0.640 n=6
Check Time 9.69s (± 0.35%) 9.75s (± 0.40%) +0.06s (+ 0.58%) 9.68s 9.78s p=0.035 n=6
Emit Time 8.28s (± 0.99%) 8.33s (± 0.82%) ~ 8.21s 8.40s p=0.422 n=6
Total Time 22.91s (± 0.50%) 23.01s (± 0.41%) ~ 22.83s 23.08s p=0.127 n=6
Compiler-Unions - node (v14.15.1, x64)
Memory used 187,640k (± 0.01%) 187,624k (± 0.01%) ~ 187,590k 187,648k p=0.378 n=6
Parse Time 1.57s (± 0.33%) 1.57s (± 0.33%) ~ 1.56s 1.57s p=0.069 n=6
Bind Time 0.84s (± 0.00%) 0.84s (± 0.90%) ~ 0.83s 0.85s p=0.598 n=6
Check Time 10.18s (± 0.65%) 10.19s (± 0.63%) ~ 10.07s 10.24s p=0.809 n=6
Emit Time 3.12s (± 0.77%) 3.16s (± 1.40%) ~ 3.10s 3.22s p=0.076 n=6
Total Time 15.72s (± 0.37%) 15.77s (± 0.66%) ~ 15.57s 15.86s p=0.199 n=6
Monaco - node (v14.15.1, x64)
Memory used 338,145k (± 0.01%) 338,145k (± 0.01%) ~ 338,118k 338,196k p=0.936 n=6
Parse Time 2.89s (± 0.80%) 2.87s (± 0.42%) ~ 2.86s 2.89s p=0.215 n=6
Bind Time 1.11s (± 0.95%) 1.10s (± 0.89%) ~ 1.09s 1.11s p=0.315 n=6
Check Time 8.08s (± 0.40%) 8.08s (± 0.43%) ~ 8.01s 8.10s p=0.808 n=6
Emit Time 4.70s (± 0.86%) 4.69s (± 0.83%) ~ 4.65s 4.76s p=0.810 n=6
Total Time 16.77s (± 0.24%) 16.73s (± 0.37%) ~ 16.66s 16.84s p=0.297 n=6
TFS - node (v14.15.1, x64)
Memory used 294,300k (± 0.00%) 294,306k (± 0.00%) ~ 294,292k 294,316k p=0.226 n=6
Parse Time 2.38s (± 1.02%) 2.38s (± 1.05%) ~ 2.35s 2.42s p=0.684 n=6
Bind Time 1.06s (± 0.38%) 1.07s (± 1.13%) ~ 1.06s 1.09s p=0.527 n=6
Check Time 7.47s (± 0.26%) 7.48s (± 0.51%) ~ 7.40s 7.50s p=0.513 n=6
Emit Time 4.29s (± 1.02%) 4.29s (± 0.69%) ~ 4.26s 4.34s p=1.000 n=6
Total Time 15.21s (± 0.42%) 15.21s (± 0.43%) ~ 15.11s 15.30s p=0.872 n=6
material-ui - node (v14.15.1, x64)
Memory used 471,384k (± 0.00%) 471,385k (± 0.01%) ~ 471,351k 471,418k p=1.000 n=6
Parse Time 3.44s (± 0.34%) 3.43s (± 0.50%) ~ 3.41s 3.45s p=0.354 n=6
Bind Time 1.00s (± 0.51%) 1.00s (± 0.75%) ~ 0.99s 1.01s p=0.784 n=6
Check Time 19.05s (± 0.59%) 19.02s (± 0.63%) ~ 18.89s 19.20s p=0.689 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 23.50s (± 0.52%) 23.45s (± 0.57%) ~ 23.32s 23.65s p=0.630 n=6
xstate - node (v14.15.1, x64)
Memory used 535,201k (± 0.00%) 535,206k (± 0.00%) ~ 535,181k 535,240k p=1.000 n=6
Parse Time 4.49s (± 1.21%) 4.44s (± 0.41%) ~ 4.42s 4.47s p=0.168 n=6
Bind Time 1.78s (± 2.74%) 1.79s (± 0.61%) ~ 1.77s 1.80s p=0.672 n=6
Check Time 3.19s (± 0.67%) 3.16s (± 0.58%) -0.03s (- 0.84%) 3.15s 3.19s p=0.040 n=6
Emit Time 0.09s (± 4.45%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=0.405 n=6
Total Time 9.54s (± 0.22%) 9.48s (± 0.38%) -0.06s (- 0.63%) 9.46s 9.54s p=0.029 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.15.1, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52427 6
Baseline main 6

TSServer

Comparison Report - main..52427
Metric main 52427 Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,358ms (± 0.32%) 2,379ms (± 0.75%) ~ 2,355ms 2,406ms p=0.054 n=6
Req 2 - geterr 5,341ms (± 0.62%) 5,403ms (± 0.40%) +62ms (+ 1.16%) 5,365ms 5,428ms p=0.020 n=6
Req 3 - references 326ms (± 1.15%) 327ms (± 1.68%) ~ 324ms 338ms p=0.806 n=6
Req 4 - navto 282ms (± 1.17%) 285ms (± 1.34%) ~ 280ms 288ms p=0.126 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 83ms (± 5.76%) 80ms (± 7.32%) ~ 72ms 90ms p=0.288 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,521ms (± 0.38%) 2,528ms (± 0.67%) ~ 2,511ms 2,558ms p=0.688 n=6
Req 2 - geterr 3,990ms (± 0.44%) 4,012ms (± 0.48%) ~ 3,996ms 4,047ms p=0.092 n=6
Req 3 - references 347ms (± 0.50%) 348ms (± 0.56%) ~ 345ms 350ms p=0.458 n=6
Req 4 - navto 292ms (± 0.71%) 294ms (± 0.36%) ~ 292ms 295ms p=0.369 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 75ms (± 8.43%) 72ms (± 5.29%) ~ 67ms 76ms p=0.627 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,167ms (± 0.70%) 3,166ms (± 0.40%) ~ 3,142ms 3,178ms p=0.423 n=6
Req 2 - geterr 1,590ms (± 0.91%) 1,591ms (± 1.03%) ~ 1,568ms 1,610ms p=1.000 n=6
Req 3 - references 103ms (± 1.50%) 104ms (± 2.14%) ~ 101ms 107ms p=0.366 n=6
Req 4 - navto 358ms (± 1.27%) 361ms (± 0.72%) ~ 358ms 365ms p=0.332 n=6
Req 5 - completionInfo count 3,136 (± 0.00%) 3,136 (± 0.00%) ~ 3,136 3,136 p=1.000 n=6
Req 5 - completionInfo 426ms (± 1.48%) 427ms (± 0.76%) ~ 424ms 433ms p=0.196 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,473ms (± 1.75%) 2,475ms (± 2.10%) ~ 2,436ms 2,544ms p=0.810 n=6
Req 2 - geterr 5,732ms (± 0.43%) 5,734ms (± 0.54%) ~ 5,686ms 5,783ms p=1.000 n=6
Req 3 - references 341ms (± 0.93%) 340ms (± 0.76%) ~ 337ms 344ms p=0.422 n=6
Req 4 - navto 278ms (± 1.03%) 281ms (± 1.37%) ~ 277ms 286ms p=0.212 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 92ms (± 6.03%) 92ms (± 6.19%) ~ 84ms 98ms p=0.742 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,669ms (± 0.55%) 2,680ms (± 0.29%) ~ 2,668ms 2,692ms p=0.229 n=6
Req 2 - geterr 4,363ms (± 0.31%) 4,358ms (± 0.47%) ~ 4,330ms 4,388ms p=1.000 n=6
Req 3 - references 358ms (± 0.64%) 361ms (± 0.34%) +3ms (+ 0.70%) 359ms 362ms p=0.050 n=6
Req 4 - navto 289ms (± 0.63%) 288ms (± 0.95%) ~ 284ms 292ms p=0.292 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 75ms (± 3.62%) 76ms (± 3.53%) ~ 73ms 79ms p=0.461 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,336ms (± 0.49%) 3,338ms (± 0.41%) ~ 3,317ms 3,351ms p=0.809 n=6
Req 2 - geterr 1,738ms (± 0.93%) 1,792ms (± 3.64%) ~ 1,730ms 1,905ms p=0.054 n=6
Req 3 - references 112ms (± 1.82%) 113ms (± 1.46%) ~ 110ms 114ms p=0.569 n=6
Req 4 - navto 344ms (± 1.42%) 345ms (± 0.88%) ~ 342ms 350ms p=0.418 n=6
Req 5 - completionInfo count 3,136 (± 0.00%) 3,136 (± 0.00%) ~ 3,136 3,136 p=1.000 n=6
Req 5 - completionInfo 433ms (± 0.70%) 433ms (± 0.35%) ~ 432ms 436ms p=0.462 n=6
Compiler-UnionsTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,569ms (± 0.63%) 2,581ms (± 0.45%) ~ 2,560ms 2,593ms p=0.173 n=6
Req 2 - geterr 6,097ms (± 0.38%) 6,071ms (± 0.49%) ~ 6,033ms 6,104ms p=0.229 n=6
Req 3 - references 357ms (± 0.38%) 358ms (± 0.52%) ~ 356ms 360ms p=1.000 n=6
Req 4 - navto 276ms (± 0.40%) 278ms (± 1.10%) ~ 276ms 284ms p=0.227 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 102ms (± 0.40%) 101ms (± 2.68%) ~ 96ms 103ms p=0.933 n=6
CompilerTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 2,798ms (± 0.45%) 2,816ms (± 0.76%) ~ 2,794ms 2,843ms p=0.261 n=6
Req 2 - geterr 4,452ms (± 0.55%) 4,450ms (± 0.40%) ~ 4,421ms 4,470ms p=0.630 n=6
Req 3 - references 402ms (± 6.86%) 384ms (± 6.08%) ~ 367ms 415ms p=0.373 n=6
Req 4 - navto 289ms (± 1.54%) 294ms (± 2.06%) ~ 286ms 301ms p=0.164 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 98ms (± 3.32%) 94ms (± 8.61%) ~ 83ms 102ms p=0.743 n=6
xstateTSServer - node (v14.15.1, x64)
Req 1 - updateOpen 3,654ms (± 1.09%) 3,671ms (± 0.93%) ~ 3,643ms 3,730ms p=0.173 n=6
Req 2 - geterr 1,842ms (± 0.86%) 1,836ms (± 0.50%) ~ 1,822ms 1,850ms p=0.470 n=6
Req 3 - references 130ms (± 2.40%) 126ms (± 2.48%) ~ 123ms 131ms p=0.052 n=6
Req 4 - navto 375ms (± 1.02%) 375ms (± 0.57%) ~ 373ms 379ms p=0.867 n=6
Req 5 - completionInfo count 3,136 (± 0.00%) 3,136 (± 0.00%) ~ 3,136 3,136 p=1.000 n=6
Req 5 - completionInfo 459ms (± 2.10%) 449ms (± 1.96%) ~ 439ms 464ms p=0.109 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.15.1, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.15.1, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.15.1, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.15.1, x64)
Benchmark Name Iterations
Current 52427 6
Baseline main 6

Startup

Comparison Report - main..52427
Metric main 52427 Delta Best Worst p-value
tsc-startup - node (v16.17.1, x64)
Execution time 141.34ms (± 0.16%) 141.19ms (± 0.20%) -0.15ms (- 0.10%) 140.42ms 145.14ms p=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time 227.53ms (± 0.36%) 225.88ms (± 0.17%) -1.64ms (- 0.72%) 224.88ms 231.72ms p=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 229.37ms (± 0.34%) 228.42ms (± 0.24%) -0.95ms (- 0.41%) 226.84ms 232.76ms p=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time 210.12ms (± 0.32%) 209.29ms (± 0.23%) -0.83ms (- 0.39%) 207.95ms 213.88ms p=0.000 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-135-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 52427 6
Baseline main 6

Developer Information:

Download Benchmark

@jakebailey jakebailey merged commit 0ce5517 into microsoft:main Mar 8, 2023
@jakebailey jakebailey mentioned this pull request Aug 7, 2023
Closed
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jakebailey jakebailey jakebailey approved these changes

@navya9singh navya9singh Awaiting requested review from navya9singh

Assignees

@jakebailey jakebailey

Labels

For Backlog Bug PRs that fix a backlog bug

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing error on overloaded methods with mismatched computed named Handle computed property names in overloads

5 participants

@Zzzen @DanielRosenwasser @typescript-bot @jakebailey @sandersn