Emit error codes when reporting diagnostics.#508
Conversation
Addresses part of issue #506.
|
👍 |
There was a problem hiding this comment.
Does 'category' need to be localized?
There was a problem hiding this comment.
|
Please do not checkin this change without change to https://github.com/Microsoft/TypeScript/blob/printDiagnosticCodes/src/harness/harness.ts#L776 Also I would recommend making the changes to https://github.com/Microsoft/TypeScript/blob/printDiagnosticCodes/src/harness/harness.ts#L791 such that it calls minimalDiagnosticsToString here itself instead of from runners (eg: https://github.com/Microsoft/TypeScript/blob/printDiagnosticCodes/src/harness/rwcRunner.ts#L155 and https://github.com/Microsoft/TypeScript/blob/printDiagnosticCodes/src/harness/projectsRunner.ts#L302) |
|
👍 |
|
@sheetalkamat I made the change to |
|
I would either do compilerrunner change as a separate iteration of this same pull request (I prefer that) or create a separate pull request for the same, But given that now we are showing error codes in error that change should be done sooner than later. |
|
Will do. I'll start working on it. Thanks! |
Emit error codes when reporting diagnostics.
Addresses part of issue #506.
Before:
After: