Dev: Have a clickable link for a new baseline created#44552
Merged
Conversation
typescript-bot
added
Author: Team
For Uncommitted Bug
orta
requested review from
RyanCavanaugh and
weswigham
and removed request for
RyanCavanaugh
| tryEnableSourceMapsForHost?(): void; | ||
| getEnvironmentVariable?(name: string): string; | ||
| getMemoryUsage?(): number | undefined; | ||
| join(...components: string[]): string |
Member
There was a problem hiding this comment.
joinPath might be clearer
weswigham
approved these changes
Jun 11, 2021
sandersn
approved these changes
Jun 23, 2021
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Looks good to me.
@DanielRosenwasser are you OK to merge this with the current naming of join?
Member
|
Still would prefer |
Contributor
Author
|
Switched it over, I'm not worried either way |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the test logging for when you make a new baseline giving a clickable link in terminals