Skip to content

fix(43939): Quick fix shouldn't be available for converting getters to async await#43944

Merged
DanielRosenwasser merged 1 commit into
microsoft:masterfrom
a-tarasyuk:fix/43939
May 6, 2021
Merged

fix(43939): Quick fix shouldn't be available for converting getters to async await#43944
DanielRosenwasser merged 1 commit into
microsoft:masterfrom
a-tarasyuk:fix/43939

Conversation

@a-tarasyuk
Copy link
Copy Markdown
Contributor

Fixes #43939

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label May 4, 2021
@DanielRosenwasser
Copy link
Copy Markdown
Member

Doesn't this also allow setters? I would just limit it to arrow functions, function expressions, declarations, and method declarations.

@a-tarasyuk
Copy link
Copy Markdown
Contributor Author

@DanielRosenwasser oke

Comment thread src/services/suggestionDiagnostics.ts Outdated
Comment thread src/services/suggestionDiagnostics.ts Outdated
Comment thread src/services/codefixes/convertToAsyncFunction.ts Outdated
@DanielRosenwasser DanielRosenwasser merged commit e0d7703 into microsoft:master May 6, 2021
@DanielRosenwasser
Copy link
Copy Markdown
Member

Thanks!

@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quick fix shouldn't be available for converting getters to async await

3 participants