Specified diagnostic for CLI flags mismatched with/out --build#43199
Merged
sheetalkamat merged 7 commits intoApr 7, 2021
Merged
Conversation
sheetalkamat
requested changes
Mar 11, 2021
Member
sheetalkamat
left a comment
sheetalkamat
left a comment
There was a problem hiding this comment.
I think it would be better for parse command line worker to take other options map and diagnostics to check of option is from different list so that build and non build both can report errors on options that are only available in other mode
JoshuaKGoldberg
force-pushed
the
only-used-with-build-flags-diagnostic
branch
from
eafe1d3 to
9b7adf4
Compare
sheetalkamat
requested changes
Mar 12, 2021
JoshuaKGoldberg
changed the title
sheetalkamat
requested changes
Mar 29, 2021
sheetalkamat
requested changes
Mar 31, 2021
added 2 commits
April 6, 2021 21:42
sheetalkamat
approved these changes
Apr 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #43196
Goes off the list of flags in https://www.typescriptlang.org/docs/handbook/project-references.html#tsc--b-commandline that require
--build. That may change soon if #43193 is resolved.