Improve deprecated suggestion node position#39702
Merged
DanielRosenwasser merged 4 commits intoAug 11, 2020
Merged
Conversation
typescript-bot
added
the
For Milestone Bug
DickvdBrink
reviewed
Jul 22, 2020
| } | ||
| } | ||
|
|
||
| function getSignautreSuggestionNode(node: CallLikeExpression): Node { |
Contributor
There was a problem hiding this comment.
Typo: getSignautreSuggestionNode -> getSignatureSuggestionNode
Member
|
@typescript-bot cherry-pick this to release-4.0 |
Collaborator
|
Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Aug 11, 2020
Collaborator
|
Hey @DanielRosenwasser, I've opened #39985 for you. |
DanielRosenwasser
pushed a commit
that referenced
this pull request
Aug 12, 2020
Component commits: cd5dde5 Improve deprecated suggestion node position 6e39ee7 fix typo a593fd0 Simplify code 58f6f3d merge helper function Co-authored-by: kingwl <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39686