Rename callbackfn params to predicate where possible#39150
Merged
sandersn merged 2 commits intoJun 18, 2020
Conversation
sandersn
approved these changes
Jun 18, 2020
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
I like the terminology change, as long as you're OK with the churn @DanielRosenwasser
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change aligns parameter naming of ES5 predicate methods (
every,filter,some) with ES6+ counterparts (find,findIndex).tc39/ecma262#1782 is a PR against the ECMA-262 to do the same. Aligning TypeScript naming would help move it forward.
This PR is #39056 with changes in
src/lib.cc @DanielRosenwasser