Skip to content

Rename callbackfn params to predicate where possible#39056

Closed
shvaikalesh wants to merge 1 commit into
microsoft:masterfrom
shvaikalesh:rename-callbackfn-to-predicate
Closed

Rename callbackfn params to predicate where possible#39056
shvaikalesh wants to merge 1 commit into
microsoft:masterfrom
shvaikalesh:rename-callbackfn-to-predicate

Conversation

@shvaikalesh
Copy link
Copy Markdown
Contributor

@shvaikalesh shvaikalesh commented Jun 12, 2020

This change aligns parameter naming of ES5 predicate methods (every, filter, some) with ES6+ counterparts (find, findIndex).

tc39/ecma262#1782 is a PR against the ECMA-262 to do the same. Aligning TypeScript naming would help move it forward.

@typescript-bot
Copy link
Copy Markdown
Collaborator

It looks like you've sent a pull request to update our 'lib' files. These files aren't meant to be edited by hand, as they consist of last-known good states of the compiler and are generated from 'src'. Unless this is necessary, consider closing the pull request and sending a separate PR to update 'src'.

@typescript-bot typescript-bot added the lib update PR modifies files in the `lib` folder label Jun 12, 2020
@ghost
Copy link
Copy Markdown

ghost commented Jun 12, 2020

CLA assistant check
All CLA requirements met.

@DanielRosenwasser
Copy link
Copy Markdown
Member

DanielRosenwasser commented Jun 17, 2020

Please reopen with the changes in src/lib

@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lib update PR modifies files in the `lib` folder

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants