Skip to content

🤖 Cherry-pick PR #36996 into release-3.8#37002

Merged
sandersn merged 1 commit into
microsoft:release-3.8from
typescript-bot:pick/36996/release-3.8
Feb 25, 2020
Merged

🤖 Cherry-pick PR #36996 into release-3.8#37002
sandersn merged 1 commit into
microsoft:release-3.8from
typescript-bot:pick/36996/release-3.8

Conversation

@typescript-bot
Copy link
Copy Markdown
Collaborator

This cherry-pick was triggered by a request on #36996
Please review the diff and merge if no changes are unexpected.
You can view the cherry-pick log here.

cc @sandersn

Component commits:
888ebf4 Fix crash on aliased,exported @enum tag in jsdoc
THe code to bind `@enum` and `@typedef` didn't handle the case that the
`@enum` was on a property assignment to an alias of module.exports.
Specifically, `x` needs to be correctly aliased to the file's symbol in
the example below:

```
var x = module.exports = {};
/** @enum {string} */
x.E = {
  A: "A"
};
```
@sandersn sandersn merged commit 98fc075 into microsoft:release-3.8 Feb 25, 2020
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants