Skip to content

Include stdout in test worker error messages#35921

Merged
sandersn merged 1 commit into
microsoft:masterfrom
jablko:patch-36
Feb 19, 2020
Merged

Include stdout in test worker error messages#35921
sandersn merged 1 commit into
microsoft:masterfrom
jablko:patch-36

Conversation

@jablko
Copy link
Copy Markdown
Contributor

@jablko jablko commented Dec 30, 2019

No description provided.

@jablko jablko force-pushed the patch-36 branch 3 times, most recently from 8afabe1 to c8490d3 Compare January 25, 2020 20:23
@sandersn sandersn added the Housekeeping Housekeeping PRs label Feb 1, 2020
@jablko jablko force-pushed the patch-36 branch 5 times, most recently from 8bc4942 to 556876a Compare February 9, 2020 17:19
@jablko jablko force-pushed the patch-36 branch 4 times, most recently from c236ad2 to f551b6e Compare February 12, 2020 21:42
Copy link
Copy Markdown
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give an example of what this changes and explain why it's useful? I don't know what conditions it would make a difference in.

@jablko
Copy link
Copy Markdown
Contributor Author

jablko commented Feb 15, 2020

Short story: I don't have an example where git/npm/docker error and stdout provides helpful context.

I added this while debugging mysterious git/npm errors, thinking there might be some context in the discarded stdout (not the case it turns out). I offer that this might be marginally helpful, even still, by saving someone debugging a future error from investigating that possibility?

Copy link
Copy Markdown
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems reasonable.

@sandersn sandersn merged commit e50f0aa into microsoft:master Feb 19, 2020
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Housekeeping Housekeeping PRs

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants