Clean up error messages for using TypeScript syntax in JavaScr…#35254
Merged
Conversation
andrewbranch
approved these changes
Nov 21, 2019
Member
andrewbranch
left a comment
andrewbranch
left a comment
There was a problem hiding this comment.
All the getJavaScriptSyntacticDiagnostics fourslash tests are failing because they have the old messages hard coded. A few months ago I exposed ts.Diagnostics to fourslash so they can be updated with that so this doesn’t happen again.
Member
Author
|
Manually dealing with these types of tests tends to be annoying so I decided to convert those tests into baseline tests. |
| return result; | ||
| } | ||
|
|
||
| public baselineSyntacticDiagnostics() { |
orta
approved these changes
Nov 22, 2019
DanielRosenwasser
force-pushed
the
removeScareQuotes
branch
from
0473a0e to
abb2bee
Compare
DanielRosenwasser
force-pushed
the
removeScareQuotes
branch
from
abb2bee to
fdafabe
Compare
DanielRosenwasser
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.