🤖 User test baselines have changed for refs/heads/master#35075
Conversation
typescript-bot
force-pushed
the
user-update-Microsoft-20191003-refs/heads/master
branch
from
1919f10 to
d7bb06d
Compare
typescript-bot
force-pushed
the
user-update-Microsoft-20191003-refs/heads/master
branch
from
d7bb06d to
e05d19b
Compare
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
My current guess is that prettier somehow changed so that allowjs is on but checkjs is off. Putting // @ts-check at the top of the file brings back the error.
| node_modules/@typescript-eslint/typescript-estree/dist/create-program/createWatchProgram.d.ts(1,8): error TS1259: Module '"/prettier/prettier/node_modules/typescript/lib/typescript"' can only be default-imported using the 'esModuleInterop' flag | ||
| src/cli/util.js(60,44): error TS2345: Argument of type 'null' is not assignable to parameter of type 'number | undefined'. | ||
| src/cli/util.js(119,38): error TS2339: Property 'sync' does not exist on type '(...args: any[]) => any'. | ||
| src/cli/util.js(413,36): error TS2345: Argument of type '{ dot: true; nodir: boolean; }' is not assignable to parameter of type 'GlobbyOptions'. |
There was a problem hiding this comment.
this error seems like it should not have disappeared.
| src/cli/util.js(413,36): error TS2345: Argument of type '{ dot: true; nodir: boolean; }' is not assignable to parameter of type 'GlobbyOptions'. | ||
| Object literal may only specify known properties, and 'nodir' does not exist in type 'GlobbyOptions'. | ||
| src/cli/util.js(507,44): error TS2345: Argument of type 'null' is not assignable to parameter of type 'number | undefined'. | ||
| src/cli/util.js(528,37): error TS2339: Property 'grey' does not exist on type 'typeof import("/prettier/prettier/node_modules/chalk/types/index")'. |
There was a problem hiding this comment.
completions work but there is no error and the type is any.
| Object literal may only specify known properties, and 'nodir' does not exist in type 'GlobbyOptions'. | ||
| src/cli/util.js(507,44): error TS2345: Argument of type 'null' is not assignable to parameter of type 'number | undefined'. | ||
| src/cli/util.js(528,37): error TS2339: Property 'grey' does not exist on type 'typeof import("/prettier/prettier/node_modules/chalk/types/index")'. | ||
| src/cli/util.js(591,16): error TS2339: Property 'type' does not exist on type 'never'. |
There was a problem hiding this comment.
in option.type, option: any but should be option: never
|
Yes, ha ha, prettier DOES want to compile using Typescript: e50ad942b |
|
So anyway, the commit is prettier/prettier@e50ad942b. It is annoying that we are not checking as much of prettier as before, but the intent of this test suite is to make sure important customers don't break on the nightly, so I think it's fine to only see breaks that prettier devs would see. I'm sure they'll reduce the size of their exclude list over time anyway. |
3 participants
This test run was triggerd by a request on #33716
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @microsoft/typescript